Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor changes to monitoring #8488

Merged
merged 11 commits into from
Jun 11, 2024
Merged

Minor changes to monitoring #8488

merged 11 commits into from
Jun 11, 2024

Conversation

freddyaboulton
Copy link
Collaborator

@freddyaboulton freddyaboulton commented Jun 6, 2024

Description

  • Prints the console url in cyan so that it's easier to see
image
  • Renames analytics to monitoring to be consistent and to differentiate from analytics collected during launch

🎯 PRs Should Target Issues

Before your create a PR, please check to see if there is an existing issue for this change. If not, please create an issue before you create this PR, unless the fix is very small.

Not adhering to this guideline will result in the PR being closed.

Tests

  1. PRs will only be merged if tests pass on CI. To run the tests locally, please set up your Gradio environment locally and run the tests: bash scripts/run_all_tests.sh

  2. You may need to run the linters: bash scripts/format_backend.sh and bash scripts/format_frontend.sh

@gradio-pr-bot
Copy link
Contributor

gradio-pr-bot commented Jun 6, 2024

🪼 branch checks and previews

Name Status URL
Spaces ready! Spaces preview
Website ready! Website preview
🦄 Changes detected! Details

Install Gradio from this PR

pip install https://gradio-builds.s3.amazonaws.com/b4e209ec222c6b7731dc28958d6c679d53da2647/gradio-4.36.1-py3-none-any.whl

Install Gradio Python Client from this PR

pip install "gradio-client @ git+https://github.com/gradio-app/gradio@b4e209ec222c6b7731dc28958d6c679d53da2647#subdirectory=client/python"

Install Gradio JS Client from this PR

npm install https://gradio-builds.s3.amazonaws.com/b4e209ec222c6b7731dc28958d6c679d53da2647/gradio-client-1.1.1.tgz

@gradio-pr-bot
Copy link
Contributor

gradio-pr-bot commented Jun 6, 2024

🦄 change detected

This Pull Request includes changes to the following packages.

Package Version
gradio patch
  • Maintainers can select this checkbox to manually select packages to update.

With the following changelog entry.

Minor changes to monitoring

Maintainers or the PR author can modify the PR title to modify this entry.

Something isn't right?

  • Maintainers can change the version label to modify the version bump.
  • If the bot has failed to detect any changes, or if this pull request needs to update multiple packages to different versions or requires a more comprehensive changelog entry, maintainers can update the changelog file directly.

@freddyaboulton freddyaboulton marked this pull request as ready for review June 6, 2024 23:08
@freddyaboulton freddyaboulton added the v: patch A change that requires a patch release label Jun 6, 2024
@abidlabs
Copy link
Member

abidlabs commented Jun 7, 2024

Code changes look good, but the cyan color is maybe a little hard to read on a light background, e.g. jupyter notebook:

image

@freddyaboulton
Copy link
Collaborator Author

I made it orange which is similar to the gradio brand and looks good in my dark terminal and jupyter. WDYT?

image Screenshot 2024-06-07 at 1 53 37 PM

@abidlabs
Copy link
Member

abidlabs commented Jun 8, 2024

I'm not sure if we should change the font color @freddyaboulton because:

  1. people have weird terminal settings sometimes and I think its better to let the default color shows rather than a hardcoded color that may not display well on their background
  2. this rich print makes the link unclickable in jupyter notebooks

Maybe there is some other way we can use to make the link stand out like demarcating with dashes above and below the link

@freddyaboulton
Copy link
Collaborator Author

Opted for just bold + underline the link @abidlabs !

@abidlabs
Copy link
Member

abidlabs commented Jun 11, 2024

Thanks @freddyaboulton! Sorry I keep running into usability issues, but I think with rich_print(), printed links are not clickable in jupyter / colab notebooks.

image

so I would suggest keeping the "*" at the beginning but using a regular print() instead

@freddyaboulton
Copy link
Collaborator Author

Ah it was working for my jupyter notebook @abidlabs . Removed the formatting from the print now.

Copy link
Collaborator

@aliabid94 aliabid94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks freddy!

@freddyaboulton
Copy link
Collaborator Author

Thank you for the reviews @aliabid94 @abidlabs !

@freddyaboulton freddyaboulton merged commit b03da67 into main Jun 11, 2024
7 checks passed
@freddyaboulton freddyaboulton deleted the minor-monitoring-changes branch June 11, 2024 22:23
@pngwn pngwn mentioned this pull request Jun 11, 2024
@pngwn pngwn mentioned this pull request Jun 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v: patch A change that requires a patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants