Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8394 df hidden items #8763

Merged
merged 4 commits into from
Jul 12, 2024
Merged

8394 df hidden items #8763

merged 4 commits into from
Jul 12, 2024

Conversation

pngwn
Copy link
Member

@pngwn pngwn commented Jul 12, 2024

Description

Weird CSS conflict with the huggingface hub search custom component. This fixes. Thanks so much @lhoestq for figuring this out!

Closes #8394.

@gradio-pr-bot
Copy link
Contributor

gradio-pr-bot commented Jul 12, 2024

🪼 branch checks and previews

Name Status URL
Spaces ready! Spaces preview
Website building...
Storybook ready! Storybook preview
🦄 Changes detected! Details

Install Gradio from this PR

pip install https://gradio-builds.s3.amazonaws.com/ed6e73bc60a7229e4a143d7f49f915aac1e380b5/gradio-4.37.2-py3-none-any.whl

Install Gradio Python Client from this PR

pip install "gradio-client @ git+https://github.com/gradio-app/gradio@ed6e73bc60a7229e4a143d7f49f915aac1e380b5#subdirectory=client/python"

Install Gradio JS Client from this PR

npm install https://gradio-builds.s3.amazonaws.com/ed6e73bc60a7229e4a143d7f49f915aac1e380b5/gradio-client-1.2.1.tgz

@gradio-pr-bot
Copy link
Contributor

gradio-pr-bot commented Jul 12, 2024

🦄 change detected

This Pull Request includes changes to the following packages.

Package Version
@gradio/dataframe patch
gradio patch
  • Maintainers can select this checkbox to manually select packages to update.

With the following changelog entry.

8394 df hidden items

Maintainers or the PR author can modify the PR title to modify this entry.

Something isn't right?

  • Maintainers can change the version label to modify the version bump.
  • If the bot has failed to detect any changes, or if this pull request needs to update multiple packages to different versions or requires a more comprehensive changelog entry, maintainers can update the changelog file directly.

@pngwn
Copy link
Member Author

pngwn commented Jul 12, 2024

Test:

pip install gradio_huggingfacehub_search

Run this demo:

import time

import gradio as gr
import pandas as pd
from gradio_huggingfacehub_search import HuggingfaceHubSearch


def run(*args):
    for i in range(1, 100):
        time.sleep(0.001)
        yield pd.DataFrame({"indices from 0 to 99 (but stops at 15 in the interface somehow unless you sort using the ▲ button)": range(i)})


with gr.Blocks() as demo:
    inputs = [
        HuggingfaceHubSearch(
            label="Hub Dataset ID",
            placeholder="you can leave this empty and click 'run'",
            search_type="dataset",
        ),
    ]
    button = gr.Button("Run")
    button.click(run, inputs, [gr.DataFrame()])

demo.launch()

Problem is present on main but not in this PR.

Copy link
Collaborator

@freddyaboulton freddyaboulton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice fix - love the repo!

@pngwn pngwn merged commit c1ecfde into main Jul 12, 2024
9 checks passed
@pngwn pngwn deleted the 8394-df-hidden-items branch July 12, 2024 17:19
@pngwn pngwn mentioned this pull request Jul 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dataframe not showing all items
3 participants