New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
examples, cache_examples fix #944
Conversation
#929 should fix checkbox and checkbox group not updating correctly. I'll be looking at Dataframe today or tomorrow. |
Is it necessary to pass the The media component should be able to handle file paths as well as data uris as the source. |
Okay removed examples_dir and made FileData.data the ultimate source, but the concatenation to prefix EDIT: just saw you created normalise_file, will logic there |
* formatting * tweaking demos
added logic to normalise_file |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great.
@aliabid94 can you rebase and resolve conflicts in this branch, as some big files entered to this branch with #955, but removed from other branches.
|
I think that failure is flake, rerunning to check. Edit: Yeah it was, all fine now. |
@aliabid94 did you rebase? Abubakar's commit "Added another demo and tweaks.." still lives in branch. |
If it is not resolved with a rebase I will edit this branch a little bit and remove that commit when I sit to the pc. |
@aliabid94 if you have not rebased pls rebase like I mentioned. And if you have, please remove this commit from this branch. (Added another demo and tweaked some of the older ones). If you can't I can take a look in the next week as well.
|
So as discussed, let's close this @aliabid94 in favor of #971 |
Fix examples issues. Examples supported for:
There were issues previously with file-type examples, e.g. Audio. Now these components use the URL instead of loading the data for examples, (much faster than converting the entire file to base64 and then sending to frontend).
Also cache_examples should work now. Functionality slightly different, now both input and output will automatically load on click if examples are cached.
Issues found in components not related to this PR: