Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Kotlin DSL friendly overall tasks #236

Closed
Vampire opened this issue Jul 4, 2023 · 6 comments · Fixed by #285
Closed

Kotlin DSL friendly overall tasks #236

Vampire opened this issue Jul 4, 2023 · 6 comments · Fixed by #285

Comments

@Vampire
Copy link
Contributor

Vampire commented Jul 4, 2023

You have the closeAndReleaseStagingRepository task (which should probably better be called closeAndReleaseStagingRepositories).
This task is always registered no matter which repositories are configured.
This is good, as then we also get type-safe accessors for the Kotlin DSL for it.
And as typically only Maven Central is configured, this is also a perfect replacement for the closeAndReleaseSonatypeStagingRepository task that does not get accessors generated.

The problem is, that I don't want to do close and release coupled.
I do the closing when doing also other publishing tasks like creating the GitHub publication.
Only after also all other tasks were successful, I want to release the repository.

So I would welcome closeStagingRepositor(y/ies) and releaseStagingRepositor(y/ies) to conveniently wire them using Kotlin DSL.
@sschuberth
Copy link

Looks like this issue is actually not so much about Kotlin DSL, but somewhat duplicates #215 and #134 (and is quite the opposite of #77).

@Vampire
Copy link
Contributor Author

Vampire commented Nov 23, 2023

Not really @sschuberth.
This is about adding summary tasks for only closing and only releasing like there is one for closing and releasing together.
This is not too tightly related to Kotlin DSL, but makes the usage better in Kotlin DSL as described above.

#215 is about the standalone closing and releasing somehow having some problem
#134 is about the possibility to upload multiple things in multiple Gradle runs and then do a close and release for them together in a separate run
#77 is not at all opposite to this request, it just requests some combination tasks that that combine publishing and closing which is totally independent of this request

Vampire added a commit to Vampire/publish-plugin that referenced this issue Nov 23, 2023
@Vampire
Add closeStagingRepository and releaseStagingRepository summary tasks (…
c8977e3 
…gradle-nexus#236)
@Vampire
Copy link
Contributor Author

Vampire commented Nov 23, 2023

Well, while we are at it, I implemented it in #285 :-D

@Vampire Vampire mentioned this issue Nov 23, 2023
Merged
@sschuberth
Copy link

Well, while we are at it, I implemented it in #285 :-D

Good luck with getting it merged (honestly, no sarcasm here).

Vampire added a commit to Vampire/publish-plugin that referenced this issue Nov 23, 2023
@Vampire
Add closeStagingRepository and releaseStagingRepository summary tasks (…
06a3209 
…gradle-nexus#236)
Vampire added a commit to Vampire/publish-plugin that referenced this issue Nov 23, 2023
@Vampire
Add closeStagingRepository and releaseStagingRepository summary tasks (…
8573062 
…gradle-nexus#236)
Vampire added a commit to Vampire/publish-plugin that referenced this issue Nov 26, 2023
@Vampire
Add closeStagingRepository and releaseStagingRepository summary tasks (…
a2787c1 
…gradle-nexus#236)
szpak pushed a commit to Vampire/publish-plugin that referenced this issue Nov 26, 2023
@Vampire @szpak
Add closeStagingRepository and releaseStagingRepository summary tasks (…
4807612 
…gradle-nexus#236)
Vampire added a commit to Vampire/publish-plugin that referenced this issue Dec 3, 2023
@Vampire
Add closeStagingRepositories and releaseStagingRepositories summary t…
eaa08f5 
…asks (gradle-nexus#236)
github-merge-queue bot pushed a commit that referenced this issue Dec 3, 2023
@Vampire
Add closeStagingRepositories and releaseStagingRepositories summary t…
381ab45 
…asks (#236) (#285)
@szpak szpak closed this as completed in #285 Dec 3, 2023
@TimvdLippe
Copy link

I think this broke the Mockito build, did it not? mockito/mockito#3259

* What went wrong:
A problem occurred evaluating script.
> Task with name 'closeAndReleaseStagingRepository' not found in root project 'mockito'.

We were using rc.1 before. If this is considered a breaking change, then we can figure out how to mitigate. Otherwise, we probably want to fix it here.

@TWiStErRob
Copy link
Collaborator

I think you need to go plural on "repositories". @szpak you should mention the breaking changes explicitly in the notes.

@oliverspryn oliverspryn mentioned this issue Mar 28, 2024
Closed
@jrhee17 jrhee17 mentioned this issue Apr 9, 2024
Merged
jrhee17 added a commit to line/armeria that referenced this issue Apr 11, 2024
@jrhee17
Upgrade dependencies for 1.28.0 (#5584)
9bc1571 
**Dependencies**

- Brave 6.0.0 -> 6.0.2
- Brotli4j 1.15.0 -> 1.16.0
- java-control-plane 1.0.42 -> 1.0.44
- Dropwizard 2.1.10 -> 2.1.12
- Dropwizard Metrics 4.2.24 -> 4.2.25
- Eureka 2.0.1 -> 2.0.2
- fastUtil 8.5.12 -> 8.5.13
- gRPC-Java 1.61.0 -> 1.63.0
- Guava 33.0.0-jre -> 33.1.0-jre
- Jackson 2.16.1 -> 2.17.0
- JCTools 4.0.2 -> 4.0.3
- Jetty10 10.0.19 -> 10.0.20
- Jetty11 11.0.19 -> 11.0.20
- Jetty12 12.0.5 -> 12.0.8
- Jetty9.4 9.4.52.v20230823 -> 9.4.54.v20240208
- Kotlin 1.9.22 -> 1.9.23
- kotlinx.coroutines 1.9.22 -> 1.9.23
- Kubernetes Client 6.10.0 -> 6.11.0
- Micrometer 1.12.2 -> 1.12.4
- Micrometer Tracing 1.2.2 -> 1.2.4
- Netty 4.1.106.Final -> 4.1.108.Final
- Netty io_uring 0.0.24.Final -> 0.0.25.Final
- protobuf-jackson 2.2.0 -> 2.5.0
- Reactor 3.6.2 -> 3.6.4
- RESTEasy 5.0.7.Final -> 5.0.9.Final
- Retrofit2 2.9.0 -> 2.11.0
- Sangria 4.0.2 -> 4.1.0
- Scala2.12 2.12.18 -> 2.12.19
- Scala2.13 2.13.12 -> 2.13.13
- Scala3 3.3.0 -> 3.4.1
- Spring6 6.1.3 -> 6.1.5
- Spring-Boot3 3.2.2 -> 3.2.4
- Tomcat8 8.5.98 -> 8.5.100
- Tomcat8 9.0.85 -> 9.0.87
- Tomcat8 10.1.18 -> 10.1.20
- Build
  - Apache HttpClient 5.3 -> 5.3.1
  - asm 9.6 -> 9.7
  - AssertJ 3.25.2 -> 3.25.3
  - Awaitility 4.2.1 -> 4.2.1
  - dagger 2.50 -> 2.51.1
  - dgs 8.2.2 -> 8.5.3
  - Error Prone 2.24.1 -> 2.26.1
  - GAX Java 2.40.0 -> 2.46.1
  - Gradle 8.5 -> 8.7
  - J2ObjC 2.8 -> 3.0.0
  - Java-WebSocket 1.5.5 -> 1.5.6
  - JUnit5 5.10.1 -> 5.10.2
  - Kafka 3.6.1 -> 3.7.0
  - krotoDC 1.0.6 -> 1.1.1
  - Gradle Nexus Publish Plugin 7.0.1 -> 7.0.2
  - SLF4J2 2.0.11 -> 2.0.12
  - Testcontainers 1.19.3 -> 1.19.7
  - Zookeeper 3.9.1 -> 3.9.2

**Additional Modifications**
- `closeAndReleaseStagingRepository` has been renamed to
`closeAndReleaseStagingRepositories`
  - gradle-nexus/publish-plugin#236
- `DnsErrorCauseException` has been introduced in Netty
  - netty/netty#13721
  - `DnsUtil#isDnsQueryTimedOut` has been updated to reflect this
- `RefreshingAddressResolver` now uses `DnsUtil#isDnsQueryTimedOut` to
determine cachability for consistency
- Note that users should sync versions between netty and armeria for
this release. Otherwise, a compliation error may occur.
- `krotodc` now requires the `protobuf-java-util` dependency
  - mscheong01/krotoDC#25
- Sangria has a breaking change regarding `DeprecationTracker`
  - sangria-graphql/sangria#1064
Dogacel pushed a commit to Dogacel/armeria that referenced this issue Jun 8, 2024
@jrhee17 @Dogacel
Upgrade dependencies for 1.28.0 (line#5584)
18090c5 
**Dependencies**

- Brave 6.0.0 -> 6.0.2
- Brotli4j 1.15.0 -> 1.16.0
- java-control-plane 1.0.42 -> 1.0.44
- Dropwizard 2.1.10 -> 2.1.12
- Dropwizard Metrics 4.2.24 -> 4.2.25
- Eureka 2.0.1 -> 2.0.2
- fastUtil 8.5.12 -> 8.5.13
- gRPC-Java 1.61.0 -> 1.63.0
- Guava 33.0.0-jre -> 33.1.0-jre
- Jackson 2.16.1 -> 2.17.0
- JCTools 4.0.2 -> 4.0.3
- Jetty10 10.0.19 -> 10.0.20
- Jetty11 11.0.19 -> 11.0.20
- Jetty12 12.0.5 -> 12.0.8
- Jetty9.4 9.4.52.v20230823 -> 9.4.54.v20240208
- Kotlin 1.9.22 -> 1.9.23
- kotlinx.coroutines 1.9.22 -> 1.9.23
- Kubernetes Client 6.10.0 -> 6.11.0
- Micrometer 1.12.2 -> 1.12.4
- Micrometer Tracing 1.2.2 -> 1.2.4
- Netty 4.1.106.Final -> 4.1.108.Final
- Netty io_uring 0.0.24.Final -> 0.0.25.Final
- protobuf-jackson 2.2.0 -> 2.5.0
- Reactor 3.6.2 -> 3.6.4
- RESTEasy 5.0.7.Final -> 5.0.9.Final
- Retrofit2 2.9.0 -> 2.11.0
- Sangria 4.0.2 -> 4.1.0
- Scala2.12 2.12.18 -> 2.12.19
- Scala2.13 2.13.12 -> 2.13.13
- Scala3 3.3.0 -> 3.4.1
- Spring6 6.1.3 -> 6.1.5
- Spring-Boot3 3.2.2 -> 3.2.4
- Tomcat8 8.5.98 -> 8.5.100
- Tomcat8 9.0.85 -> 9.0.87
- Tomcat8 10.1.18 -> 10.1.20
- Build
  - Apache HttpClient 5.3 -> 5.3.1
  - asm 9.6 -> 9.7
  - AssertJ 3.25.2 -> 3.25.3
  - Awaitility 4.2.1 -> 4.2.1
  - dagger 2.50 -> 2.51.1
  - dgs 8.2.2 -> 8.5.3
  - Error Prone 2.24.1 -> 2.26.1
  - GAX Java 2.40.0 -> 2.46.1
  - Gradle 8.5 -> 8.7
  - J2ObjC 2.8 -> 3.0.0
  - Java-WebSocket 1.5.5 -> 1.5.6
  - JUnit5 5.10.1 -> 5.10.2
  - Kafka 3.6.1 -> 3.7.0
  - krotoDC 1.0.6 -> 1.1.1
  - Gradle Nexus Publish Plugin 7.0.1 -> 7.0.2
  - SLF4J2 2.0.11 -> 2.0.12
  - Testcontainers 1.19.3 -> 1.19.7
  - Zookeeper 3.9.1 -> 3.9.2

**Additional Modifications**
- `closeAndReleaseStagingRepository` has been renamed to
`closeAndReleaseStagingRepositories`
  - gradle-nexus/publish-plugin#236
- `DnsErrorCauseException` has been introduced in Netty
  - netty/netty#13721
  - `DnsUtil#isDnsQueryTimedOut` has been updated to reflect this
- `RefreshingAddressResolver` now uses `DnsUtil#isDnsQueryTimedOut` to
determine cachability for consistency
- Note that users should sync versions between netty and armeria for
this release. Otherwise, a compliation error may occur.
- `krotodc` now requires the `protobuf-java-util` dependency
  - mscheong01/krotoDC#25
- Sangria has a breaking change regarding `DeprecationTracker`
  - sangria-graphql/sangria#1064
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@Vampire @sschuberth @TWiStErRob @TimvdLippe