Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish to Maven Central #58

Closed
eriwen opened this issue Jul 21, 2021 · 7 comments · Fixed by #59
Closed

Publish to Maven Central #58

eriwen opened this issue Jul 21, 2021 · 7 comments · Fixed by #59
Assignees

Comments

@eriwen
Copy link
Contributor

eriwen commented Jul 21, 2021

Context

We should resolve this library from Maven Central so consumers do not have to access repo.gradle.org. This will be faster and more stable.

@marcphilipp has recommended that we use the group org.gradle.exemplar. I agree.

@marcphilipp
Copy link
Contributor

Using the io.github.gradle-nexus.publish-plugin would allow automating dealing with Sonatype's OSSRH Nexus.

@britter
Copy link
Member

britter commented Jul 22, 2021

I think if we move to a new groupId we should also align the rest of the naming in this project. The status quo is:

repository name exemplar
subprojects sample-check and sample-discovery
root package `org.gradle.samples`
GAV `org.gradle:sample-check:0.12.6`

My proposal:

repository name exemplar
subprojects check and discovery
root package `org.gradle.exemplar`
GAV `org.gradle.exemplar:check:0.12.6` & `org.gradle.exemplar:discovery:0.12.6`

@big-guy
Copy link
Member

big-guy commented Jul 22, 2021

Does GE use exemplar or sample-check?

@britter
Copy link
Member

britter commented Jul 23, 2021

Yes, we're using it to test the Test Distribution Gradle plugin manual.

@big-guy
Copy link
Member

big-guy commented Aug 5, 2021

this LGTM

@eriwen
Copy link
Contributor Author

eriwen commented Aug 5, 2021

Also LGTM :shipit:

@pbielicki pbielicki linked a pull request Aug 9, 2021 that will close this issue
@pbielicki pbielicki self-assigned this Aug 9, 2021
@pbielicki
Copy link
Member

TODO:

  • Add project to the TeamCity
  • Add all required env variables to it (e.g. for publishing to Maven Central signing the artifacts)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants