Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update plugin portal badge #52

Merged
merged 5 commits into from Jan 21, 2021
Merged

Update plugin portal badge #52

merged 5 commits into from Jan 21, 2021

Conversation

runningcode
Copy link
Member

@runningcode runningcode commented Jan 20, 2021 •
edited

Check it here

etiennestuder
etiennestuder requested changes Jan 20, 2021
View reviewed changes
Copy link
Member

@etiennestuder etiennestuder left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you change the badge label to 'Plugin Portal' please?

marcphilipp
marcphilipp suggested changes Jan 20, 2021
View reviewed changes
Copy link
Contributor

@marcphilipp marcphilipp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this for me:
Screenshot 2021-01-20 at 18 01 47

Maybe the space in the URL needs to be replaced with %20?

@runningcode
Copy link
Member Author

@marcphilipp woops, thanks for catching. fixed.

@etiennestuder
Copy link
Member

etiennestuder commented Jan 21, 2021 •
edited

@runningcode You can merge it as soon as it is fully working, without a further review from me.

@runningcode runningcode merged commit 1c030a3 into master Jan 21, 2021
@runningcode runningcode deleted the no/plugin-portal-badge branch January 21, 2021 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcphilipp marcphilipp marcphilipp approved these changes

@etiennestuder etiennestuder Awaiting requested review from etiennestuder

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@runningcode @etiennestuder @marcphilipp