Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create JFR flame graphs on Java 9+ #77

Closed
oehme opened this issue Jun 12, 2018 · 3 comments
Closed

Create JFR flame graphs on Java 9+ #77

oehme opened this issue Jun 12, 2018 · 3 comments

Comments

@oehme
Copy link
Contributor

oehme commented Jun 12, 2018

No description provided.

@javabrett
Copy link
Contributor

It's probably already been noticed that as well as the lib jars being renamed, all the packages have been relocated from com.jrockit.mc to com.oracle.jmc. Not sure which of the following options is preferred (all refer to oehme/jfr-flame-graph):

  • Pre-shadow to a common package-name and check/hope for API stability. Produce a JDK8 and JDK9 all version of that lib with the correct dependency. Clearly the JFR recording format has changed.
  • Split out the source and compile separately for JDK8 and JFK9, and produce different -all versions. Downside is that two source-trees have to be independently maintained.

@javabrett
Copy link
Contributor

Actually JDK9 is EOL but I imagine this applies to JDK10 also.

@oehme
Copy link
Contributor Author

oehme commented Jan 6, 2019

Fixed by 2db305f. Note that I'm still investigating an issue where Java 11 delivers way less CPU samples than earlier versions. Memory samples on the other hand are fine. This may be a JDK or OS bug, I'm not sure yet.

@oehme oehme closed this as completed Jan 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants