Skip to content
This repository has been archived by the owner on Aug 19, 2020. It is now read-only.

Automatically generate type-safe accessors for contributed extensions #235

Closed
bamboo opened this issue Jan 18, 2017 · 4 comments
Closed

Automatically generate type-safe accessors for contributed extensions #235

bamboo opened this issue Jan 18, 2017 · 4 comments
Assignees
@bamboo
Labels
a:feature in:kotlin-dsl-compilation re:ease-of-use re:groovy-parity
Milestone
0.8.0

Comments

@bamboo
Copy link
Member

bamboo commented Jan 18, 2017 •
edited by eskatos
Loading

Apply plugins block against empty project and see which extensions are added.

Then use code generator and build script compiler as in the metadata file driven solution.

  • pros
    • it is automatic
  • cons
    • won't take imperative plugins into account
@bamboo bamboo added this to the 0.8.0 milestone Jan 18, 2017
@eskatos eskatos changed the title Automatically generate type-safe accessors for contributed extensions / conventions Automatically generate type-safe accessors for contributed extensions Jan 20, 2017
@bamboo bamboo modified the milestones: 0.9.0, 0.8.0 Feb 6, 2017
@bamboo bamboo modified the milestones: 1.1.0, 0.9.0, 0.8.0 Feb 23, 2017
@bamboo bamboo self-assigned this Feb 24, 2017
bamboo added a commit that referenced this issue Feb 24, 2017
@bamboo
Automatically generate type-safe accessors for contributed extensions
dff110e 
See #235
bamboo added a commit that referenced this issue Feb 24, 2017
@bamboo
Benefit from automatically generated type-safe accessors
cecd89f 
See #235
@bamboo
Copy link
Member Author

bamboo commented Feb 24, 2017

type-safe-accessors

bamboo added a commit that referenced this issue Feb 24, 2017
@bamboo
Prove accessors are regenerated whenever the set of plugins change
d4d232c 
See #235
bamboo added a commit that referenced this issue Feb 24, 2017
@bamboo
Accept unorthodox extension names
3478f06 
See #235
bamboo added a commit that referenced this issue Feb 28, 2017
@bamboo
Omit accessors for extensions with illegal names
6132039 
See #235
@pioterj
Copy link
Member

pioterj commented Feb 28, 2017

I can't reproduce what I see in the screencast. Is it on master yet?

@bamboo
Copy link
Member Author

bamboo commented Feb 28, 2017

It is.

You have to be running the latest Kotlin plugin from the EAP channel (1.1.0-rc-91-*) and reimport samples/hello-world.

@pioterj
Copy link
Member

pioterj commented Mar 2, 2017

Thanks, @bamboo. It's working for me with Kotlin plugin 1.1.0-release-IJ2016.3-1.

I ended up cloning a fresh copy of the project to make it work. "Refresh all Gradle projects" and importing project again didn't help.

bamboo added a commit that referenced this issue Mar 2, 2017
@bamboo
Put automatic generation of extension accessors behind feature flag
e75d7d9 
Due to the potential for build script compilation failures resulting
from unaccessible extension types or illegal extension names at the
moment, automatic accessors will only be generated if the project
property `org.gradle.script.lang.kotlin.accessors.auto` is set to
`"true"`.

See #235
bamboo added a commit that referenced this issue Mar 2, 2017
@bamboo
Enable automatic accessors
effbc1b 
See #235
@bamboo bamboo closed this as completed Mar 6, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bamboo bamboo

Labels
a:feature in:kotlin-dsl-compilation re:ease-of-use re:groovy-parity
Projects
None yet
Milestone
0.8.0
Development

No branches or pull requests
2 participants
@bamboo @pioterj