-
Notifications
You must be signed in to change notification settings - Fork 4.6k
/
PmdPlugin.java
235 lines (209 loc) · 11.4 KB
/
PmdPlugin.java
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
/*
* Copyright 2011 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
package org.gradle.api.plugins.quality;
import com.google.common.annotations.VisibleForTesting;
import com.google.common.collect.ImmutableSet;
import org.gradle.api.JavaVersion;
import org.gradle.api.artifacts.Configuration;
import org.gradle.api.file.FileCollection;
import org.gradle.api.file.ProjectLayout;
import org.gradle.api.file.RegularFile;
import org.gradle.api.internal.ConventionMapping;
import org.gradle.api.internal.artifacts.configurations.ConfigurationRolesForMigration;
import org.gradle.api.internal.artifacts.configurations.RoleBasedConfigurationContainerInternal;
import org.gradle.api.plugins.quality.internal.AbstractCodeQualityPlugin;
import org.gradle.api.provider.Provider;
import org.gradle.api.provider.ProviderFactory;
import org.gradle.api.tasks.SourceSet;
import org.gradle.jvm.toolchain.JavaLauncher;
import org.gradle.jvm.toolchain.JavaToolchainService;
import org.gradle.jvm.toolchain.JavaToolchainSpec;
import org.gradle.jvm.toolchain.internal.CurrentJvmToolchainSpec;
import org.gradle.util.internal.VersionNumber;
import javax.inject.Inject;
import java.io.File;
import java.util.ArrayList;
import java.util.Collections;
import java.util.List;
import java.util.Set;
import static org.gradle.api.internal.lambdas.SerializableLambdas.action;
/**
* A plugin for the <a href="https://pmd.github.io/">PMD</a> source code analyzer.
* <p>
* Declares a <code>pmd</code> configuration which needs to be configured with the PMD library to be used.
* <p>
* Declares a <code>pmdAux</code> configuration to add transitive compileOnly dependencies to the PMD's auxclasspath. This is only needed if PMD complains about NoClassDefFoundError during type
* resolution.
* <p>
* For each source set that is to be analyzed, a {@link Pmd} task is created and configured to analyze all Java code.
* <p>
* All PMD tasks (including user-defined ones) are added to the <code>check</code> lifecycle task.
*
* @see PmdExtension
* @see Pmd
* @see <a href="https://docs.gradle.org/current/userguide/pmd_plugin.html">PMD plugin reference</a>
*/
public abstract class PmdPlugin extends AbstractCodeQualityPlugin<Pmd> {
// When updating DEFAULT_PMD_VERSION, also update links in Pmd and PmdExtension!
public static final String DEFAULT_PMD_VERSION = "6.55.0";
private static final String PMD_ADDITIONAL_AUX_DEPS_CONFIGURATION = "pmdAux";
private PmdExtension extension;
@Override
protected String getToolName() {
return "PMD";
}
@Override
protected Class<Pmd> getTaskType() {
return Pmd.class;
}
@Inject
protected JavaToolchainService getToolchainService() {
throw new UnsupportedOperationException();
}
@Override
protected CodeQualityExtension createExtension() {
extension = project.getExtensions().create("pmd", PmdExtension.class, project);
extension.setToolVersion(DEFAULT_PMD_VERSION);
extension.getRulesMinimumPriority().convention(5);
extension.getIncrementalAnalysis().convention(true);
extension.getMaxFailures().convention(0);
extension.getThreads().convention(1);
extension.setRuleSetFiles(project.getLayout().files());
extension.ruleSetsConvention(project.getProviders().provider(() -> ruleSetsConvention(extension)));
conventionMappingOf(extension).map("targetJdk", () ->
getDefaultTargetJdk(getJavaPluginExtension().getSourceCompatibility()));
return extension;
}
public TargetJdk getDefaultTargetJdk(JavaVersion javaVersion) {
try {
return TargetJdk.toVersion(javaVersion.toString());
} catch (IllegalArgumentException ignored) {
// TargetJDK does not include 1.1, 1.2 and 1.8;
// Use same fallback as PMD
return TargetJdk.VERSION_1_4;
}
}
@Override
protected void createConfigurations() {
super.createConfigurations();
Configuration auxClasspath = project.getConfigurations().dependencyScopeUnlocked(PMD_ADDITIONAL_AUX_DEPS_CONFIGURATION, additionalAuxDepsConfiguration -> {
additionalAuxDepsConfiguration.setDescription("The additional libraries that are available for type resolution during analysis");
additionalAuxDepsConfiguration.setVisible(false);
});
getJvmPluginServices().configureAsRuntimeClasspath(auxClasspath);
}
@Override
protected void configureConfiguration(Configuration configuration) {
configureDefaultDependencies(configuration);
}
@Override
protected void configureTaskDefaults(Pmd task, String baseName) {
Configuration configuration = project.getConfigurations().getAt(getConfigurationName());
configureTaskConventionMapping(configuration, task);
configureReportsConventionMapping(task, baseName);
configureToolchains(task);
}
private static List<String> ruleSetsConvention(PmdExtension extension) {
if (extension.getRuleSetConfig() == null && extension.getRuleSetFiles().isEmpty()) {
return new ArrayList<>(Collections.singletonList("category/java/errorprone.xml"));
} else {
return Collections.emptyList();
}
}
private void configureDefaultDependencies(Configuration configuration) {
configuration.defaultDependencies(dependencies ->
calculateDefaultDependencyNotation(extension.getToolVersion())
.stream()
.map(project.getDependencies()::create)
.forEach(dependencies::add)
);
}
private void configureTaskConventionMapping(Configuration configuration, final Pmd task) {
ConventionMapping taskMapping = task.getConventionMapping();
taskMapping.map("pmdClasspath", () -> configuration);
taskMapping.map("ruleSets", () -> extension.getRuleSets());
taskMapping.map("ruleSetConfig", () -> extension.getRuleSetConfig());
taskMapping.map("ruleSetFiles", () -> extension.getRuleSetFiles());
taskMapping.map("consoleOutput", () -> extension.isConsoleOutput());
taskMapping.map("targetJdk", () -> extension.getTargetJdk());
task.getRulesMinimumPriority().convention(extension.getRulesMinimumPriority());
task.getMaxFailures().convention(extension.getMaxFailures());
task.getIncrementalAnalysis().convention(extension.getIncrementalAnalysis());
task.getThreads().convention(extension.getThreads());
task.getIgnoreFailuresProperty().convention(project.provider(() -> extension.isIgnoreFailures()));
}
private void configureReportsConventionMapping(Pmd task, final String baseName) {
ProjectLayout layout = project.getLayout();
ProviderFactory providers = project.getProviders();
Provider<RegularFile> reportsDir = layout.file(providers.provider(() -> extension.getReportsDir()));
task.getReports().all(action(report -> {
report.getRequired().convention(true);
report.getOutputLocation().convention(
layout.getProjectDirectory().file(providers.provider(() -> {
String reportFileName = baseName + "." + report.getName();
return new File(reportsDir.get().getAsFile(), reportFileName).getAbsolutePath();
}))
);
}));
}
private void configureToolchains(Pmd task) {
Provider<JavaLauncher> javaLauncherProvider = getToolchainService().launcherFor(new CurrentJvmToolchainSpec(project.getObjects()));
task.getJavaLauncher().convention(javaLauncherProvider);
project.getPluginManager().withPlugin("java-base", p -> {
JavaToolchainSpec toolchain = getJavaPluginExtension().getToolchain();
task.getJavaLauncher().convention(getToolchainService().launcherFor(toolchain).orElse(javaLauncherProvider));
});
}
@VisibleForTesting
static Set<String> calculateDefaultDependencyNotation(final String versionString) {
final VersionNumber toolVersion = VersionNumber.parse(versionString);
if (toolVersion.compareTo(VersionNumber.version(5)) < 0) {
return Collections.singleton("pmd:pmd:" + versionString);
} else if (toolVersion.compareTo(VersionNumber.parse("5.2.0")) < 0) {
return Collections.singleton("net.sourceforge.pmd:pmd:" + versionString);
} else if (toolVersion.getMajor() < 7) {
return Collections.singleton("net.sourceforge.pmd:pmd-java:" + versionString);
}
// starting from version 7, PMD is split into multiple modules
return ImmutableSet.of(
"net.sourceforge.pmd:pmd-java:" + versionString,
"net.sourceforge.pmd:pmd-ant:" + versionString
);
}
@Override
protected void configureForSourceSet(final SourceSet sourceSet, final Pmd task) {
task.setDescription("Run PMD analysis for " + sourceSet.getName() + " classes");
task.setSource(sourceSet.getAllJava());
ConventionMapping taskMapping = task.getConventionMapping();
RoleBasedConfigurationContainerInternal configurations = project.getConfigurations();
Configuration compileClasspath = configurations.getByName(sourceSet.getCompileClasspathConfigurationName());
Configuration pmdAdditionalAuxDepsConfiguration = configurations.getByName(PMD_ADDITIONAL_AUX_DEPS_CONFIGURATION);
// TODO: Consider checking if the resolution consistency is enabled for compile/runtime.
@SuppressWarnings("deprecation") Configuration pmdAuxClasspath = configurations.migratingUnlocked(sourceSet.getName() + "PmdAuxClasspath", ConfigurationRolesForMigration.RESOLVABLE_DEPENDENCY_SCOPE_TO_RESOLVABLE);
pmdAuxClasspath.extendsFrom(compileClasspath, pmdAdditionalAuxDepsConfiguration);
pmdAuxClasspath.setVisible(false);
// This is important to get transitive implementation dependencies. PMD may load referenced classes for analysis so it expects the classpath to be "closed" world.
getJvmPluginServices().configureAsRuntimeClasspath(pmdAuxClasspath);
// We have to explicitly add compileClasspath here because it may contain classes that aren't part of the compileClasspathConfiguration. In particular, compile
// classpath of the test sourceSet contains output of the main sourceSet.
taskMapping.map("classpath", () -> {
// It is important to subtract compileClasspath and not pmdAuxClasspath here because these configurations are resolved differently (as a compile and as a
// runtime classpath). Compile and runtime entries for the same dependency may resolve to different files (e.g. compiled classes directory vs. jar).
FileCollection nonConfigurationClasspathEntries = sourceSet.getCompileClasspath().minus(compileClasspath);
return sourceSet.getOutput().plus(nonConfigurationClasspathEntries).plus(pmdAuxClasspath);
});
}
}