/
NullabilityChangesTest.kt
245 lines (226 loc) · 9.09 KB
/
NullabilityChangesTest.kt
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
/*
* Copyright 2020 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
package gradlebuild.binarycompatibility
import org.junit.Test
class NullabilityChangesTest : AbstractBinaryCompatibilityTest() {
@Test
fun `from non-null returning to null returning is breaking (java)`() {
checkNotBinaryCompatibleJava(
v1 = """
public class Source {
public String nonFinalField = "some";
public final String finalField = "some";
public String foo() { return "bar"; }
}
""",
v2 = """
public class Source {
@Nullable public String nonFinalField = null;
@Nullable public final String finalField = null;
@Nullable public String foo() { return "bar"; }
}
"""
) {
assertHasErrors(
"Field nonFinalField: Nullability breaking change.",
"Field finalField: From non-nullable to nullable breaking change.",
"Method com.example.Source.foo(): From non-null returning to null returning breaking change."
)
assertHasNoWarning()
assertHasNoInformation()
}
}
@Test
fun `from non-null returning to null returning is breaking (kotlin)`() {
checkNotBinaryCompatibleKotlin(
v1 = """
class Source {
val someVal: String = "some"
var someVar: String = "some"
fun foo(): String = "bar"
}
""",
v2 = """
class Source {
val someVal: String? = null
var someVar: String? = null
fun foo(): String? = null
}
"""
) {
assertHasErrors(
"Method com.example.Source.foo(): From non-null returning to null returning breaking change.",
"Method com.example.Source.getSomeVal(): From non-null returning to null returning breaking change.",
"Method com.example.Source.getSomeVar(): From non-null returning to null returning breaking change."
)
assertHasWarnings(
"Method com.example.Source.setSomeVar(java.lang.String): Parameter 0 nullability changed from non-nullable to nullable"
)
assertHasNoInformation()
}
}
@Test
fun `from null accepting to non-null accepting is breaking (java)`() {
checkNotBinaryCompatibleJava(
v1 = """
public class Source {
public Source(@Nullable String some) {}
@Nullable public String nonFinalField = null;
public String foo(@Nullable String bar) { return "some"; }
}
""",
v2 = """
public class Source {
public Source(String some) {}
public String nonFinalField = "some";
public String foo(String bar) { return bar; }
}
"""
) {
assertHasErrors(
"Field nonFinalField: Nullability breaking change.",
"Method com.example.Source.foo(java.lang.String): Parameter 0 from null accepting to non-null accepting breaking change.",
"Constructor com.example.Source(java.lang.String): Parameter 0 from null accepting to non-null accepting breaking change."
)
assertHasNoWarning()
assertHasNoInformation()
}
}
@Test
fun `from null accepting to non-null accepting is breaking (kotlin)`() {
checkNotBinaryCompatibleKotlin(
v1 = """
class Source(some: String?) {
var someVar: String? = null
fun foo(bar: String?) {}
}
""",
v2 = """
class Source(some: String) {
var someVar: String = "some"
fun foo(bar: String) {}
}
"""
) {
assertHasErrors(
"Method com.example.Source.foo(java.lang.String): Parameter 0 from null accepting to non-null accepting breaking change.",
"Method com.example.Source.setSomeVar(java.lang.String): Parameter 0 from null accepting to non-null accepting breaking change.",
"Constructor com.example.Source(java.lang.String): Parameter 0 from null accepting to non-null accepting breaking change."
)
assertHasWarnings(
"Method com.example.Source.getSomeVar(): Return nullability changed from nullable to non-nullable"
)
assertHasNoInformation()
}
}
@Test
fun `from null returning to non-null returning is not breaking (java)`() {
checkBinaryCompatibleJava(
v1 = """
public class Source {
@Nullable public final String finalField = null;
@Nullable public String foo(String bar) { return bar; }
}
""",
v2 = """
public class Source {
public final String finalField = null;
public String foo(String bar) { return bar; }
}
"""
) {
assertHasNoError()
assertHasWarnings(
"Field finalField: Nullability changed from nullable to non-nullable",
"Method com.example.Source.foo(java.lang.String): Return nullability changed from nullable to non-nullable"
)
assertHasNoInformation()
}
}
@Test
fun `from null returning to non-null returning is not breaking (kotlin)`() {
checkBinaryCompatibleKotlin(
v1 = """
class Source {
val someVal: String? = null
fun foo(): String? = null
}
""",
v2 = """
class Source {
val someVal: String = "some"
fun foo(): String = "bar"
}
"""
) {
assertHasNoError()
assertHasWarnings(
"Method com.example.Source.foo(): Return nullability changed from nullable to non-nullable",
"Method com.example.Source.getSomeVal(): Return nullability changed from nullable to non-nullable"
)
assertHasNoInformation()
}
}
@Test
fun `from non-null accepting to null accepting is not breaking (java)`() {
checkBinaryCompatibleJava(
v1 = """
public class Source {
public Source(String some) {}
public String foo(String bar) { return bar; }
}
""",
v2 = """
public class Source {
public Source(@Nullable String some) {}
public String foo(@Nullable String bar) { return "some"; }
}
"""
) {
assertHasNoError()
assertHasWarnings(
"Method com.example.Source.foo(java.lang.String): Parameter 0 nullability changed from non-nullable to nullable",
"Constructor com.example.Source(java.lang.String): Parameter 0 nullability changed from non-nullable to nullable"
)
assertHasNoInformation()
}
}
@Test
fun `from non-null accepting to null accepting is not breaking (kotlin)`() {
checkBinaryCompatibleKotlin(
v1 = """
class Source(some: String) {
fun foo(bar: String) {}
}
operator fun Source.invoke(arg: String) {}
""",
v2 = """
class Source(some: String?) {
fun foo(bar: String?) {}
}
operator fun Source.invoke(arg: String?) {}
"""
) {
assertHasNoError()
assertHasWarnings(
"Method com.example.Source.foo(java.lang.String): Parameter 0 nullability changed from non-nullable to nullable",
"Constructor com.example.Source(java.lang.String): Parameter 0 nullability changed from non-nullable to nullable",
"Method com.example.SourceKt.invoke(com.example.Source,java.lang.String): Parameter 1 nullability changed from non-nullable to nullable"
)
assertHasNoInformation()
}
}
}