Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discourage the use of a Provider<T> where T is a type that is lazy #10610

Open
adammurdoch opened this issue Aug 4, 2018 · 3 comments
Open
Labels
a:feature A new functionality in:provider-api property lazy provider MapProperty ListProperty DirectoryProperty in:work-validation task validation, warnings, disable optimizations

Comments

@adammurdoch
Copy link
Member

Using a provider of a lazy type is generally pointless, and the lazy type can be used directly instead. Find ways to avoid the following:

  • Provider<FileCollection> (or any subtype such as FileTree)
  • Provider<Provider<?>> (or any subtype of Provider such as Property)
  • Provider<DomainObjectCollection<?>> (or any subtype such as TaskCollection).

This might include validation, documentation, clearer APIs (for example changing these types to extend Provider).

@lacasseio lacasseio transferred this issue from gradle/gradle-native Sep 11, 2019
@stale
Copy link

stale bot commented Oct 15, 2020

This issue has been automatically marked as stale because it has not had recent activity. Given the limited bandwidth of the team, it will be automatically closed if no further activity occurs. If you're interested in how we try to keep the backlog in a healthy state, please read our blog post on how we refine our backlog. If you feel this is something you could contribute, please have a look at our Contributor Guide. Thank you for your contribution.

@stale stale bot added the stale label Oct 15, 2020
@eskatos
Copy link
Member

eskatos commented Oct 16, 2020

We still want to do this stale bot

@stale stale bot removed the stale label Oct 16, 2020
@jjohannes jjohannes added in:configuration-cache Configuration Caching in:configuration-model lazy api, domain object container and removed in:configuration-cache Configuration Caching labels Mar 22, 2021
@bmuskalla bmuskalla added in:provider-api property lazy provider MapProperty ListProperty DirectoryProperty and removed in:configuration-model lazy api, domain object container labels Apr 9, 2021
@stale
Copy link

stale bot commented Apr 11, 2022

This issue has been automatically marked as stale because it has not had recent activity. Given the limited bandwidth of the team, it will be automatically closed if no further activity occurs. If you're interested in how we try to keep the backlog in a healthy state, please read our blog post on how we refine our backlog. If you feel this is something you could contribute, please have a look at our Contributor Guide. Thank you for your contribution.

@stale stale bot added the stale label Apr 11, 2022
@eskatos eskatos removed the stale label Apr 12, 2022
@jbartok jbartok added a:feature A new functionality in:work-validation task validation, warnings, disable optimizations labels May 25, 2023
@FrauBoes FrauBoes self-assigned this May 26, 2023
@FrauBoes FrauBoes added this to the 8.3 milestone May 26, 2023
@asodja asodja modified the milestones: 8.3, 8.3 RC1 May 26, 2023
@FrauBoes FrauBoes modified the milestones: 8.3 RC1, 8.3 Jun 26, 2023
@lptr lptr removed the @execution label Feb 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:feature A new functionality in:provider-api property lazy provider MapProperty ListProperty DirectoryProperty in:work-validation task validation, warnings, disable optimizations
Projects
None yet
Development

No branches or pull requests

9 participants