Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show option name too for unset mandatory task property #11174

Open
Vampire opened this issue Oct 30, 2019 · 3 comments
Open

Show option name too for unset mandatory task property #11174

Vampire opened this issue Oct 30, 2019 · 3 comments
Labels
a:feature A new functionality in:writing-tasks task option

Comments

@Vampire
Copy link
Contributor

Vampire commented Oct 30, 2019

If you have a mandatory task property with an @Option annotation with a different option name than the the task property, only the property name is shown in the error message.

For example for this property:

    @get:Input
    @get:Option(
            option = "fxVersion",
            description = "The JavaFX version to prepare"
    )
    abstract val version: Property<String>

if the property is not set, the error says No value has been specified for property 'version'.
While this is correct, in this case it is intentional, as the property is meant to always be set from commandline.
It would be nice if the error would also suggest using the commandline option to set the property.

@Vampire Vampire added a:feature A new functionality from:contributor labels Oct 30, 2019
@stale
Copy link

stale bot commented Dec 3, 2020

This issue has been automatically marked as stale because it has not had recent activity. Given the limited bandwidth of the team, it will be automatically closed if no further activity occurs. If you're interested in how we try to keep the backlog in a healthy state, please read our blog post on how we refine our backlog. If you feel this is something you could contribute, please have a look at our Contributor Guide. Thank you for your contribution.

@stale stale bot added the stale label Dec 3, 2020
@Vampire
Copy link
Contributor Author

Vampire commented Dec 8, 2020

Still relevant with 6.7.1.

@stale stale bot removed the stale label Dec 8, 2020
@ljacomet ljacomet added in:writing-tasks task option and removed to-triage labels Jul 7, 2021
@stale
Copy link

stale bot commented Jul 12, 2022

This issue has been automatically marked as stale because it has not had recent activity. Given the limited bandwidth of the team, it will be automatically closed if no further activity occurs. If you're interested in how we try to keep the backlog in a healthy state, please read our blog post on how we refine our backlog. If you feel this is something you could contribute, please have a look at our Contributor Guide. Thank you for your contribution.

@stale stale bot added the stale label Jul 12, 2022
@stale stale bot removed the stale label Aug 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:feature A new functionality in:writing-tasks task option
Projects
None yet
Development

No branches or pull requests

4 participants