Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make global transforms cache additive only #11478

Open
lptr opened this issue Nov 27, 2019 · 2 comments
Open

Make global transforms cache additive only #11478

lptr opened this issue Nov 27, 2019 · 2 comments
Labels
a:chore Minor issue without significant impact in:artifact-transforms

Comments

@lptr
Copy link
Member

lptr commented Nov 27, 2019

Currently global transforms are executed in a workspace that is directly inside the cache directory. If a transform fails for some environmental reason, during the next run the files in the workspace will be modified. This conflicts with keeping the cache directory additive (i.e. files can appear there but never removed or modified).


cc: @gradle/build-cache

@lptr
Copy link
Member Author

lptr commented Nov 27, 2019

One way to do this is to run in a separate workspace and then move the files into the cache on success.

@wolfs wolfs added this to the 6.3 RC1 milestone Jan 8, 2020
@wolfs wolfs modified the milestones: 6.3 RC1, 6.4 RC1 Feb 28, 2020
@wolfs wolfs modified the milestones: 6.4 RC1, 6.5 RC1 Apr 6, 2020
@wolfs wolfs modified the milestones: 6.5 RC1, 6.6 RC1 May 7, 2020
@wolfs wolfs removed this from the 6.6 RC1 milestone Jun 4, 2020
@stale
Copy link

stale bot commented Apr 17, 2022

This issue has been automatically marked as stale because it has not had recent activity. Given the limited bandwidth of the team, it will be automatically closed if no further activity occurs. If you're interested in how we try to keep the backlog in a healthy state, please read our blog post on how we refine our backlog. If you feel this is something you could contribute, please have a look at our Contributor Guide. Thank you for your contribution.

@stale stale bot added the stale label Apr 17, 2022
@lptr lptr removed the stale label Apr 20, 2022
@lptr lptr added the a:chore Minor issue without significant impact label Sep 12, 2023
@lptr lptr removed the @execution label Feb 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:chore Minor issue without significant impact in:artifact-transforms
Projects
None yet
Development

No branches or pull requests

3 participants