Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the user guide section about supported builds for build comparison #1266

Merged

Conversation

Vampire
Copy link
Contributor

@Vampire Vampire commented Jan 27, 2017

No description provided.

@eriwen
Copy link
Contributor

eriwen commented Jan 27, 2017

@Vampire thanks for the PR. I don't see your name in our CLA system. Can you please confirm you've signed one?

@Vampire
Copy link
Contributor Author

Vampire commented Jan 27, 2017

@eriwen there were times where each version of Gradle had at least one contribution from me, so yes, I signed one already. ;-)

@Vampire
Copy link
Contributor Author

Vampire commented Jan 27, 2017

To be exact, you have it since 10.07.2014 as requested by @alkemist

@eriwen
Copy link
Contributor

eriwen commented Jan 27, 2017

@Vampire sorry about the confusion — We changed the system that manages CLAs a couple years ago. We're all good here.

@eriwen eriwen added cla:yes and removed cla:no labels Jan 27, 2017
@eriwen
Copy link
Contributor

eriwen commented Jan 27, 2017

This update looks accurate. Thank you @Vampire for your contribution!

@eriwen eriwen merged commit e935f1d into gradle:master Jan 27, 2017
@Vampire Vampire deleted the supported-builds-doc-for-build-comparison branch January 28, 2017 21:54
@Vampire
Copy link
Contributor Author

Vampire commented Feb 1, 2017

@eriwen You are welcome. Btw., I should be mentioned as contributor this time again, shouldn't I? ;-)

@eriwen
Copy link
Contributor

eriwen commented Feb 2, 2017

@Vampire Indeed :) 4464682

@Vampire
Copy link
Contributor Author

Vampire commented Feb 2, 2017

Great, thanks. One more issue though, you link to #1266, but the text says #1029 ;-)

@eriwen
Copy link
Contributor

eriwen commented Feb 2, 2017

@Vampire Argh, stupid typo. Fixed now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants