Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Daemon --enable-preview should be part of the inputs #12984

Open
melix opened this issue Apr 30, 2020 · 2 comments
Open

Daemon --enable-preview should be part of the inputs #12984

melix opened this issue Apr 30, 2020 · 2 comments
Labels
a:bug in:java-plugins java-library, java, java-base, java-platform, java-test-fixtures

Comments

@melix
Copy link
Contributor

melix commented Apr 30, 2020

Expected Behavior

When not using forking, there are VM options which "leak" to the Java compiler. I discovered, when investigating #12680, that one "fix" was to add --enable-preview to the daemon options. However, this flag is not considered as part of the cache key for Java compilation.

As a consequence, you can pass compilation by doing:

org.gradle.jvmargs=--enable-preview

then comment that line, and re-run compilation: everything is up-to-date. Run with --rerun-tasks and compilation fails as it should.

@jjohannes jjohannes removed the @jvm label Mar 22, 2021
@bmuskalla bmuskalla added the in:java-plugins java-library, java, java-base, java-platform, java-test-fixtures label Apr 7, 2021
@stale
Copy link

stale bot commented Apr 13, 2022

This issue has been automatically marked as stale because it has not had recent activity. Given the limited bandwidth of the team, it will be automatically closed if no further activity occurs. If you're interested in how we try to keep the backlog in a healthy state, please read our blog post on how we refine our backlog. If you feel this is something you could contribute, please have a look at our Contributor Guide. Thank you for your contribution.

@stale stale bot added the stale label Apr 13, 2022
@melix
Copy link
Contributor Author

melix commented Apr 17, 2022

still relevant

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:bug in:java-plugins java-library, java, java-base, java-platform, java-test-fixtures
Projects
None yet
Development

No branches or pull requests

3 participants