Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use fewer thread locals for MutationGuard #13857

Open
wolfs opened this issue Jul 20, 2020 · 1 comment
Open

Use fewer thread locals for MutationGuard #13857

wolfs opened this issue Jul 20, 2020 · 1 comment
Assignees
Labels
a:performance-improvement Performance improvement potential @configuration-cache in:core-utilities base services

Comments

@wolfs
Copy link
Member

wolfs commented Jul 20, 2020

We now use one ThreadLocal per DefaultMutationGuard instance. This caused a memory leak-like slowdown. We fixed the slowdown by removing the ThreadLocal when possible in #13428.

A better solution would be to have fewer ThreadLocals in the first place, e.g. by only having one ThreadLocal which retains a map of all the mutation guards.


cc: @gradle/execution

@stale
Copy link

stale bot commented Apr 17, 2022

This issue has been automatically marked as stale because it has not had recent activity. Given the limited bandwidth of the team, it will be automatically closed if no further activity occurs. If you're interested in how we try to keep the backlog in a healthy state, please read our blog post on how we refine our backlog. If you feel this is something you could contribute, please have a look at our Contributor Guide. Thank you for your contribution.

@stale stale bot added the stale label Apr 17, 2022
@lptr lptr removed the stale label Apr 20, 2022
@ov7a ov7a added a:feature A new functionality a:performance-improvement Performance improvement potential to-triage and removed a:feature A new functionality labels Aug 8, 2023
@ov7a ov7a added in:core-utilities base services and removed to-triage labels Sep 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:performance-improvement Performance improvement potential @configuration-cache in:core-utilities base services
Projects
None yet
Development

No branches or pull requests

5 participants