Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure signing tasks for different publication don't overwrite signatures #15568

Open
wolfs opened this issue Dec 14, 2020 · 3 comments
Open
Labels
a:feature A new functionality has:workaround Indicates that the issue has a workaround in:publishing-plugins ivy-publish maven-publish in:signing-plugin

Comments

@wolfs
Copy link
Member

wolfs commented Dec 14, 2020

When two publications contain the same file (like the main JAR), then the signing tasks for the publications will create the signatures in the same place. For example publishing to maven and ivy repositories in the same build causes the signature to be produced twice.

We shouldn't have tasks which produce the same files. A solution could be to have a signing task (artifact transform?) for each artifact, not for each publication.


cc: @gradle/execution

@stale
Copy link

stale bot commented May 31, 2022

This issue has been automatically marked as stale because it has not had recent activity. Given the limited bandwidth of the team, it will be automatically closed if no further activity occurs. If you're interested in how we try to keep the backlog in a healthy state, please read our blog post on how we refine our backlog. If you feel this is something you could contribute, please have a look at our Contributor Guide. Thank you for your contribution.

@stale stale bot added the stale label May 31, 2022
@wolfs
Copy link
Member Author

wolfs commented Jun 1, 2022

I think we should fix this.

@stale stale bot removed the stale label Jun 1, 2022
@vlsi
Copy link
Contributor

vlsi commented Mar 10, 2023

Here's a workaround:

// Workaround for https://github.com/gradle/gradle/issues/15568
tasks.withType<AbstractPublishToMaven>().configureEach {
    mustRunAfter(tasks.withType<Sign>())
}

@ov7a ov7a added a:feature A new functionality has:workaround Indicates that the issue has a workaround labels Aug 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:feature A new functionality has:workaround Indicates that the issue has a workaround in:publishing-plugins ivy-publish maven-publish in:signing-plugin
Projects
None yet
Development

No branches or pull requests

5 participants