Adding the ability for ivy repo's to use a non-standard pattern #1813
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With the current implementation of the PluginRepositories it's not possible for the user to be able to specify a repo that doens't meet the "ivy" standard layout. Many people do not, so it's impossible to use this feature. This chang will allow for users to specify more info about their repositories.
oehme
suggested changes
Apr 20, 2017
| * @param config The closure used to configure the layout. | ||
| * An instance of {@link RepositoryLayout} is passed as a parameter to the closure. | ||
| */ | ||
| void layout(String layoutName, Closure config); |
There was a problem hiding this comment.
Closure shouldn't be necessary, added by DSL decoration.
There was a problem hiding this comment.
I can remove it, do you want me to also remove it from the RepositoryHandler that it was copied from?
There was a problem hiding this comment.
No, we'll remove that when we remove all the old Closure overloads.
|
@ethankhall We're branching for the release next Monday, so in order to make it into 4.0, we need the test coverage for this change this week. |
Removed the Closure method from IvyPluginRepository because it's done for us automatically. Added an integ test to validate that it's possible to specify a custom directory layout.
|
Thanks for the notification @oehme, I've added the test and removed the method. Let me know if there's anything else you need from me. |
oehme
approved these changes
Apr 28, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the current implementation of the PluginRepositories it's not
possible for the user to be able to specify a repo that doens't meet the
"ivy" standard layout. Many people do not, so it's impossible to use
this feature.
This change will allow for users to specify more info about their
repositories.
Gradle Core Team Checklist
@sinceand@Incubatingannotations for all public APIs