Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump the PMD version used by the plugin to 5.6.1 #1858

Merged
merged 1 commit into from May 3, 2017

Conversation

sschuberth
Copy link
Contributor

@sschuberth sschuberth commented Apr 20, 2017

This replaces PR #1623.

Context

To benefit from the fix for pmd/pmd#232. This also includes the fix for pmd/pmd#337.

Contributor Checklist

  • Review Contribution Guidelines
  • Sign Gradle CLA
  • Link to Design Spec for changes that affect more than 1 public API (that is, not in an internal package) or updates to > 20 files
  • Provide integration tests (under <subproject>/src/integTest) to verify changes from a user perspective
  • Provide unit tests (under <subproject>/src/test) to verify logic
  • Update User Guide, DSL Reference, and Javadoc for public-facing changes
  • Ensure that tests pass locally: ./gradlew quickCheck <impacted-subproject>:check

Gradle Core Team Checklist

  • Verify design and implementation
  • Verify test coverage and CI build status
  • Verify documentation including proper use of @since and @Incubating annotations for all public APIs
  • Recognize contributor in release notes

@sschuberth
Copy link
Contributor Author

I have verified that

./gradlew codeQuality:integTest --tests org.gradle.api.plugins.quality.PmdPluginAuxclasspathIntegrationTest

passes locally.

@bmuschko
Copy link
Contributor

What was the actual issue that has been fixed? Can you point us to a description of it?

Did you run the tests you mentioned above on Windows?

@bmuschko bmuschko added a:chore Minor issue without significant impact cla:yes in:pmd-plugin labels Apr 20, 2017
@sschuberth
Copy link
Contributor Author

What was the actual issue that has been fixed? Can you point us to a description of it?

The link is in the commit message: pmd/pmd#337

Did you run the tests you mentioned above on Windows?

Yes, because only Windows was affected, as only Windows does not permit to delete unclosed files.

@sschuberth sschuberth changed the title Bump the PMD version used by the plugin to 5.5.6 Bump the PMD version used by the plugin to 5.6.0 Apr 25, 2017
@sschuberth
Copy link
Contributor Author

@bmuschko Meanwhile PMD 5.6.0 was released, and I've upgraded my PR to it.

@adangel
Copy link
Contributor

adangel commented May 1, 2017

@sschuberth Could you please update this PR to PMD 5.6.1 - the original fix (in 5.5.6 and 5.6.0) was unfortunately incomplete and caused another problem. PMD 5.6.1 has the final fix in it (as well es 5.5.7). See pmd/pmd#364 / pmd/pmd@9fae304
Thanks!

For the release notes see

    https://github.com/pmd/pmd/releases/tag/pmd_releases%2F5.6.1

This fixes several bugs like e.g.

    pmd/pmd#232

and also

    pmd/pmd#337
    pmd/pmd#364

which blocked the previous upgrade to PMD 5.5.5, see

    gradle#1623
@sschuberth sschuberth changed the title Bump the PMD version used by the plugin to 5.6.0 Bump the PMD version used by the plugin to 5.6.1 May 1, 2017
@sschuberth
Copy link
Contributor Author

Done @adangel, thanks for notifying.

@w25r w25r self-assigned this May 3, 2017
@w25r w25r merged commit c0b15be into gradle:master May 3, 2017
@sschuberth sschuberth deleted the pmd-upgrade branch May 3, 2017 19:32
@eriwen
Copy link
Contributor

eriwen commented May 6, 2017

@w25r please don't forget to add this to release notes, thanking the contributor.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:chore Minor issue without significant impact in:pmd-plugin
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants