New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump the PMD version used by the plugin to 5.6.1 #1858
Conversation
I have verified that
passes locally. |
What was the actual issue that has been fixed? Can you point us to a description of it? Did you run the tests you mentioned above on Windows? |
The link is in the commit message: pmd/pmd#337
Yes, because only Windows was affected, as only Windows does not permit to delete unclosed files. |
@bmuschko Meanwhile PMD 5.6.0 was released, and I've upgraded my PR to it. |
@sschuberth Could you please update this PR to PMD 5.6.1 - the original fix (in 5.5.6 and 5.6.0) was unfortunately incomplete and caused another problem. PMD 5.6.1 has the final fix in it (as well es 5.5.7). See pmd/pmd#364 / pmd/pmd@9fae304 |
For the release notes see https://github.com/pmd/pmd/releases/tag/pmd_releases%2F5.6.1 This fixes several bugs like e.g. pmd/pmd#232 and also pmd/pmd#337 pmd/pmd#364 which blocked the previous upgrade to PMD 5.5.5, see gradle#1623
Done @adangel, thanks for notifying. |
@w25r please don't forget to add this to release notes, thanking the contributor. |
This replaces PR #1623.
Context
To benefit from the fix for pmd/pmd#232. This also includes the fix for pmd/pmd#337.
Contributor Checklist
internal
package) or updates to > 20 files<subproject>/src/integTest
) to verify changes from a user perspective<subproject>/src/test
) to verify logic./gradlew quickCheck <impacted-subproject>:check
Gradle Core Team Checklist
@since
and@Incubating
annotations for all public APIs