Error extracting downloaded toolchain for `JvmImplementation.J9` #19382

bigdaz · 2021-12-21T21:37:47Z

When choosing the "Open J9" Java Toolchain implementation as described in the docs, there is an error extracting the the downloaded Toolchain distribution, resulting in a build failure.

Expected Behavior

The J9 toolchain distribution should be successfully downloaded, provisioned and used.

Current Behavior

The build fails with this error occurring when extracting the toolchain:

* What went wrong:
Execution failed for task ':compileJava'.
> Error while evaluating property 'javaCompiler' of task ':compileJava'
   > Failed to calculate the value of task ':compileJava' property 'javaCompiler'.
      > Unable to download toolchain matching these requirements: {languageVersion=11, vendor=ADOPTOPENJDK, implementation=J9}
         > Could not copy tar entry /Users/daz/dev/playground/java-tool/HOME/jdks/adoptopenjdk-11-x64-mac.tar.gz!1413453464414134534642/./ to '/Users/daz/dev/playground/java-tool/HOME/.tmp/expandedArchives/adoptopenjdk-11-x64-mac.tar.gz_09fc3ceb3762da51449cb5292ffc4737/1413453464414134534642/.'.
            > Failed to create parent directory '/Users/daz/dev/playground/java-tool/HOME/.tmp/expandedArchives/adoptopenjdk-11-x64-mac.tar.gz_09fc3ceb3762da51449cb5292ffc4737/1413453464414134534642' when creating directory '/Users/daz/dev/playground/java-tool/HOME/.tmp/expandedArchives/adoptopenjdk-11-x64-mac.tar.gz_09fc3ceb3762da51449cb5292ffc4737/1413453464414134534642/.'

Steps to Reproduce

Checkout the main branch of https://github.com/bigdaz/gradle-toolchain-issues
./gradlew -g HOME build

Build scan URL: https://scans.gradle.com/s/ri37b7rtrdmf6/failure#1

The text was updated successfully, but these errors were encountered:

bigdaz · 2021-12-21T22:01:19Z

Interesting: looking at the build scan there are a bunch of Unicode [U+0000] characters in the Tar entry name: https://scans.gradle.com/s/ri37b7rtrdmf6/failure?anchor=e30&focused-exception-line=0-1-2-3-4-5-0#1

jbartok · 2021-12-23T13:20:28Z

Conclusions so far:

when servicing the toolchain spec in the reproducer (languageVersion 11, vendor ADOPTOPENJDK, implementation J9), our auto-provisioning system requests a download from here: https://api.adoptopenjdk.net/v3/binary/latest/11/ga/mac/x64/jdk/openj9/normal/adoptopenjdk
the actual response we get is: https://github.com/ibmruntimes/semeru11-binaries/releases/download/jdk-11.0.13%2B8_openj9-0.29.0/ibm-semeru-open-jdk_x64_mac_11.0.13_8_openj9-0.29.0.tar.gz
our code for extracting such archives, basically TarFileTree, fails to do so on this particular archive (the org.apache.tools.tar code we use produces some TarEntry instances with corrupted names, ie. String with lots of zero bytes in them, which then get turned into file names and things just go bye-bye from there); this is the case with all relatively recent versions of our codebase
something is very weird with this jar, but the actual tar utility from MacOS can handle it... which makes it even weirder...
btw. if we don't request the J9 implementation, then we get a completely different jar and none of these problems happen
things work with other J9 implementation jars too properly, for example if the language level is 16
so there is something about this particular Jar, but so far I fail to realize what exaclty

jbartok · 2021-12-27T13:31:24Z

I've tracked this down to the exact change in Ant that introduces the code which is broken. It was introduced when they switched from 1.8 to 1.9.

The buggy code is this prefix shenanigans which wasn't there until then and in case of this particular compressed tar archive doesn't behave as expected.

I think that the tar.gz has some fault too, it probably has some header values which aren't correct and lead to the manifestation of the Ant bug.

What to do about it... The whole Ant project, as it's set up, in my opinion, just screams "we don't really need your contribution", I got a bit discouraged when even contemplating submitting a bug report, but that's probably what we'll need to do.

Or switch to some other tool for decompressing tars. I'm sure we can find something a bit more modern.

Let's discuss it internally.

jbartok · 2021-12-27T13:44:39Z

We have decided to try to report this to Adoptium, maybe they'll fix the archive.

bigdaz · 2021-12-29T01:52:59Z

things work with other J9 implementation jars too properly, for example if the language level is 16

@jbartok This doesn't match my experience: I've tested with various languageVersion settings and get the same failure for some other versions.

11: FAIL https://scans.gradle.com/s/dvz6wphf3clkk
14: SUCCESS https://scans.gradle.com/s/wydezhdpw7sgk/performance/network-activity
15: SUCCESS https://scans.gradle.com/s/wqsomyc7e5uni/performance/network-activity
16: FAIL https://scans.gradle.com/s/26jtwv3g56z2u
17: FAIL https://scans.gradle.com/s/xdd72zurio4vq

Note that I start with an empty Gradle User Home in each case, to avoid getting false positives/negatives due to #19383

jbartok · 2021-12-29T10:47:48Z

Ok, good to know. I've only tried with 11 and 16. I will double-check and report those to Adoptium too.

jbartok · 2022-01-06T09:33:21Z

@bigdaz Turns out that the archives that are NOT ok are the regular IBM Semeru Runtime ones (ibm-semeru-open-jdk_x64_mac_xxx.tar.gz).

The ones that work, are different somehow, IBM doesn't provide Semeru archives for Java 14 & 15. What Adoptium provides are some kind of OpenJDK ones, called OpenJDK14U-jdk_x64_mac_openj9_14.0.2_12_openj9-0.21.0.tar.gz and OpenJDK15U-jdk_x64_mac_openj9_15.0.2_7_openj9-0.24.0.tar.gz. Anyways, these work just fine, we can ignore them for now.

I'm trying to contact IBM, let's see if they are willing to look into and do something about their Semeru archives. But, just as Ant, they really don't make it easy... Let's see if I can get anywhere with them.

jbartok · 2022-01-07T07:39:16Z

Finally found the right place to submit the issue: ibmruntimes/Semeru-Runtimes#15

jbartok · 2022-01-12T09:26:35Z

Note to myself: in the meantime I should come up with a PR for replacing the Ant code when uncompressing the archives.

ljacomet · 2022-01-17T13:23:48Z

This turns out to be somewhat tricky to fix, so will not be done for 7.4

gabrieljones · 2022-01-17T15:14:27Z

I just hit this in gradle v7.3.3 with:

build.gradle.kts

// ...
java {
  toolchain {
    languageVersion.set(JavaLanguageVersion.of(17))
  }
}
// ...

Works fine on my MacBook, but breaks on our Jenkins build servers.

build log

Downloading https://<corp proxy>/v3/binary/latest/17/ga/linux/x64/jdk/hotspot/normal/adoptopenjdk to /XXXXX/jenkins/.gradle/jdks/adoptopenjdk-17-x64-linux.tar.gz

FAILURE: Build failed with an exception.

* What went wrong:
A problem occurred configuring root project 'pipeline-template'.
> Failed to calculate the value of task ':compileJava' property 'javaCompiler'.
   > Unable to download toolchain matching these requirements: {languageVersion=17, vendor=any, implementation=vendor-specific}
       > Could not copy tar entry /XXXXX/jenkins/.gradle/jdks/adoptopenjdk-17-x64-linux.tar.gz!jdk-17.0.1+12/lib/server/classes.jsa to '/XXXXX/jenkins/.gradle/jdks/jdk-17.0.1+12/lib/server/classes.jsa'.
          > /XXXXX/jenkins/.gradle/jdks/jdk-17.0.1+12/lib/server/classes.jsa (No such file or directory)

Anyone have a workaround yet?

Edit:
My current workaround is to predownload and install with curl and tar shell commands like so:

Jenkinsfile

// ...
    stage('pre download toolchain') {
      steps {
        sh 'curl https://<corp proxy>/v3/binary/latest/17/ga/linux/x64/jdk/hotspot/normal/adoptopenjdk --create-dirs -fsSLo ~/.gradle/jdks/adoptopenjdk-17-x64-linux.tar.gz'
        sh 'tar -xf ~/.gradle/jdks/adoptopenjdk-17-x64-linux.tar.gz -C ~/.gradle/jdks/'
      }
    }
// ...

gabrieljones · 2022-01-17T16:13:27Z

Unable to reproduce in Github Actions:

Downloading https://api.adoptopenjdk.net/v3/binary/latest/17/ga/linux/x64/jdk/hotspot/normal/adoptopenjdk to /home/runner/.gradle/jdks/adoptopenjdk-17-x64-linux.tar.gz
Installed adoptopenjdk-17-x64-linux.tar.gz into /home/runner/.gradle/jdks/jdk-17.0.1+12

-- https://github.com/gabrieljones/gradle-toolchain-issues/runs/4843169424

jbartok · 2022-03-09T10:28:42Z

I just hit this in gradle v7.3.3 with:

build.gradle.kts

// ...
java {
  toolchain {
    languageVersion.set(JavaLanguageVersion.of(17))
  }
}
// ...

Works fine on my MacBook, but breaks on our Jenkins build servers.

build log

Downloading https://<corp proxy>/v3/binary/latest/17/ga/linux/x64/jdk/hotspot/normal/adoptopenjdk to /XXXXX/jenkins/.gradle/jdks/adoptopenjdk-17-x64-linux.tar.gz

FAILURE: Build failed with an exception.

* What went wrong:
A problem occurred configuring root project 'pipeline-template'.
> Failed to calculate the value of task ':compileJava' property 'javaCompiler'.
   > Unable to download toolchain matching these requirements: {languageVersion=17, vendor=any, implementation=vendor-specific}
       > Could not copy tar entry /XXXXX/jenkins/.gradle/jdks/adoptopenjdk-17-x64-linux.tar.gz!jdk-17.0.1+12/lib/server/classes.jsa to '/XXXXX/jenkins/.gradle/jdks/jdk-17.0.1+12/lib/server/classes.jsa'.
          > /XXXXX/jenkins/.gradle/jdks/jdk-17.0.1+12/lib/server/classes.jsa (No such file or directory)

Anyone have a workaround yet?

Edit: My current workaround is to predownload and install with curl and tar shell commands like so:

Jenkinsfile

// ...
    stage('pre download toolchain') {
      steps {
        sh 'curl https://<corp proxy>/v3/binary/latest/17/ga/linux/x64/jdk/hotspot/normal/adoptopenjdk --create-dirs -fsSLo ~/.gradle/jdks/adoptopenjdk-17-x64-linux.tar.gz'
        sh 'tar -xf ~/.gradle/jdks/adoptopenjdk-17-x64-linux.tar.gz -C ~/.gradle/jdks/'
      }
    }
// ...

@gabrieljones this has nothing to do with this current issue; pls. file a separate issue for it and we'll try to investigate.

EdGue42 · 2022-05-13T07:03:01Z

What is the reason that this has been moved out to Gradle 8?

Why do we have to wait for the next major version update?

Gradle 8 is really problematic, as A) who knows when it will be coming and B) there might be various issues preventing us to moving to gradle 8.

amankr55 · 2022-07-19T12:32:12Z

@jbartok Is it fixed already with Gradle 7.5? If not, are there any plans to fix it with next Gradle release before Gradle 8?

jbartok · 2022-07-22T07:44:59Z

@amankr55 changing the archive decompression library will only happen in Gradle 8, no sooner; it's too big of a change for us to do in a non-major release

bigdaz added a:bug to-triage labels Dec 21, 2021

bigdaz mentioned this issue Dec 21, 2021

Changes to toolChain implementation are ignored #19383

Closed

jbartok added in:toolchains Java Toolchains and removed to-triage labels Dec 22, 2021

jbartok self-assigned this Dec 22, 2021

jbartok added this to the 7.4 RC1 milestone Dec 22, 2021

ljacomet removed this from the 7.4 RC1 milestone Dec 27, 2021

ljacomet added this to the 7.4 RC1 milestone Jan 12, 2022

jbartok mentioned this issue Jan 13, 2022

Replace Ant compression library for toolchain archives #19570

Merged

ljacomet modified the milestones: 7.4 RC1, 7.5 RC1 Jan 17, 2022

ljacomet added the affects-version:7.4 label Jan 17, 2022

ljacomet mentioned this issue Feb 28, 2022

Toolchain binaries may contain . directory causing unpacking to fail. #20039

Closed

jbartok modified the milestones: 7.5 RC1, 8.0 RC1 Mar 9, 2022

bot-gradle closed this as completed in 464b7db Oct 28, 2022

eskatos added affects-version:7.5 affects-version:7.6 labels Oct 28, 2022

github-actions bot mentioned this issue Feb 12, 2023

Update gradle to 7.6 red6/dmn-check#178

Merged

StefMa mentioned this issue Mar 5, 2024

Add Gradle toolchain support apple/pkl#262

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Error extracting downloaded toolchain for `JvmImplementation.J9` #19382

Error extracting downloaded toolchain for `JvmImplementation.J9` #19382

bigdaz commented Dec 21, 2021

bigdaz commented Dec 21, 2021

jbartok commented Dec 23, 2021

jbartok commented Dec 27, 2021

jbartok commented Dec 27, 2021

bigdaz commented Dec 29, 2021

jbartok commented Dec 29, 2021

jbartok commented Jan 6, 2022

jbartok commented Jan 7, 2022

jbartok commented Jan 12, 2022

ljacomet commented Jan 17, 2022

gabrieljones commented Jan 17, 2022 •

edited

gabrieljones commented Jan 17, 2022

jbartok commented Mar 9, 2022

EdGue42 commented May 13, 2022

amankr55 commented Jul 19, 2022

jbartok commented Jul 22, 2022

Error extracting downloaded toolchain for JvmImplementation.J9 #19382

Error extracting downloaded toolchain for JvmImplementation.J9 #19382

Comments

bigdaz commented Dec 21, 2021

Expected Behavior

Current Behavior

Steps to Reproduce

bigdaz commented Dec 21, 2021

jbartok commented Dec 23, 2021

jbartok commented Dec 27, 2021

jbartok commented Dec 27, 2021

bigdaz commented Dec 29, 2021

jbartok commented Dec 29, 2021

jbartok commented Jan 6, 2022

jbartok commented Jan 7, 2022

jbartok commented Jan 12, 2022

ljacomet commented Jan 17, 2022

gabrieljones commented Jan 17, 2022 • edited

gabrieljones commented Jan 17, 2022

jbartok commented Mar 9, 2022

EdGue42 commented May 13, 2022

amankr55 commented Jul 19, 2022

jbartok commented Jul 22, 2022

Error extracting downloaded toolchain for `JvmImplementation.J9` #19382

Error extracting downloaded toolchain for `JvmImplementation.J9` #19382

gabrieljones commented Jan 17, 2022 •

edited