New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Play 2.6 #1992
Add support for Play 2.6 #1992
Conversation
671bb4f
to
8fde689
Compare
e2847f1
to
11fa798
Compare
Hey @benmccann. Thanks again for the PR. I'll be taking a look at this for the next release too. I'll let you know when I get back around to this. |
@big-guy @benmccann Play 2.6.0 is generally available as of today, so it'd be good to get this in. |
Hey @benmccann @wsargent, I started running this through our CI infrastructure. Should there be a I also checked the typesafe repos, JCenter and |
I see there's a 2.10 version published on Maven. I'm guessing we don't publish 2.11 and 2.12 versions because that library is only used by our SBT plugin, which only runs Scala 2.10 |
Ah, I didn't think about going down a version :) It looks like the only part we actually use from that library is |
@big-guy we can publish a 2.11 version of the library. Filed an issue in the Play tracker playframework/playframework#7687 |
I attempted to just remove our dependency on So we don't have to have a 2.11 version of it. |
Ok. That looks simpler anyway |
case PLAY_2_6_X: | ||
// TODO: create a TwirlJavaCompiler for Twirl 1.3.x that uses the Java compiler interface | ||
// Rename TwirlCompiler to TwirlScalaCompiler | ||
// Waiting for https://github.com/playframework/twirl/pull/136 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
playframework/twirl#136 was already merged and released. Maybe this can be updated to use play.japi.twirl.compiler.TwirlCompiler
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep, that was the plan. I need #2062 to be merged first though
I merged this into master (with some fixes for our integration tests). It'll be in 4.2 |
Awesome. Thanks! |
Context
Adds support for Play 2.6, which will soon be released. I'm a committer to Play and employee of LinkedIn
Contributor Checklist
internal
package) or updates to > 20 files<subproject>/src/integTest
) to verify changes from a user perspective<subproject>/src/test
) to verify logic./gradlew quickCheck :platformPlay:check
Gradle Core Team Checklist
@since
and@Incubating
annotations for all public APIs