Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Follow up for optimistic locking changes #20687 #20702

Closed
wolfs opened this issue May 9, 2022 · 0 comments · Fixed by #20966
Closed

Follow up for optimistic locking changes #20687 #20702

wolfs opened this issue May 9, 2022 · 0 comments · Fixed by #20966
Labels
in:virtual-file-system VFS, file system watching, snapshots
Milestone
7.6 RC1

Comments

@wolfs
Copy link
Member

wolfs commented May 9, 2022

There are some improvements we should do to wrap up the introduction of optimistic locking in the VFS done in #20687.

  • Ensure that everything necessary for snapshotting is done inside of VirtualFileSystem.store(). Currently, the calls to stat are outside of the store() call.
  • Inline VfsRootReference into AbstractVirtualFileSystem: VfsRootReference is only used for locking on all the mutable state in VirtualFileSystem and its subclasses, not only to guard access to the VFS root. Therefore, it should be inlined into AbstractVirtualFileSystem.

cc: @gradle/execution
@wolfs wolfs added this to the 7.6 RC1 milestone May 9, 2022
@wolfs wolfs mentioned this issue May 9, 2022
Merged
@wolfs wolfs added the in:virtual-file-system VFS, file system watching, snapshots label May 9, 2022
@wolfs wolfs mentioned this issue Jun 8, 2022
Merged
This was referenced Jan 5, 2023
Closed
Closed
Closed
Closed
@github-actions github-actions bot mentioned this issue Feb 12, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
in:virtual-file-system VFS, file system watching, snapshots
Projects
None yet
Milestone
7.6 RC1
Development

Successfully merging a pull request may close this issue.

Follow up for optimistic locking changes gradle/gradle
1 participant
@wolfs