Handle null Throwable stack trace to avoid NullPointerException #2168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes gradle#1618 When an exception with null pointer stackTrace (usually a mock exception) is thrown in test, ExceptionPlaceholder can't handle it correctly and throws a NPE. This commit set the stackTrace to empty array if it's null. An unit test is provided.
bmuschko
suggested changes
Jul 28, 2017
There was a problem hiding this comment.
Thanks for providing the pull request. Could you please also add an integration test that demonstrates the correct behavior? The reporter of the problem provided a sample project that might be useful.
|
@blindpirate Just making sure you saw my comments. Are you planning to address those soon? |
|
Sure, I missed it. I'll tackle it today. |
|
Sorry for the delay, and this is the first time I write an integration test from scratch, so please let me know if there's anything inappropriate. |
bmuschko
approved these changes
Aug 3, 2017
bmuschko
changed the title
bmuschko
changed the title
bmuschko
changed the title
|
Thanks for the pull request. It has been merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
See #1618
Contributor Checklist
<subproject>/src/test) to verify logic./gradlew quickCheck <impacted-subproject>:check