Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"withVariantReselection" API broken #21781

Closed
bingranl opened this issue Aug 31, 2022 · 5 comments
Closed

"withVariantReselection" API broken #21781

bingranl opened this issue Aug 31, 2022 · 5 comments
Assignees
Labels
a:bug @core Issue owned by GBT Core in:dependency-resolution engine metadata
Milestone

Comments

@bingranl
Copy link

Expected Behavior

The "withVariantReselection" API should work and the demo project should work.

Current Behavior

The demo project doesn't work and the API is broken.

Context

Android Gradle Plugin is trying to integrate that API to have better support of reading javadoc and source from Android Studio.

Steps to Reproduce

It can be easily reproduced with the demo project.

@jbartok jbartok added in:dependency-resolution engine metadata and removed to-triage labels Sep 2, 2022
@big-guy big-guy added this to the 7.6 RC1 milestone Sep 2, 2022
@big-guy big-guy self-assigned this Sep 2, 2022
@big-guy big-guy added the @core Issue owned by GBT Core label Sep 7, 2022
@DPUkyle
Copy link
Member

DPUkyle commented Sep 13, 2022

@bingranl I doublechecked the instructions in the demo project's README and it's now working fine for me. I think @big-guy had to make two or three small changes after you reported this issue.

Please give it another try and confirm the example is working for you.

@bingranl
Copy link
Author

Yeah, this works for me now. Thanks!

@bingranl
Copy link
Author

Actually the demo is not using a normal nightly version but with gradle-7.6-branch-sg_76_artifact_resolution-20220831231945+0000. So if I use the latest nightly version, it won't work. So I wonder if the fix is checked in to main? @big-guy

@big-guy
Copy link
Member

big-guy commented Sep 22, 2022

@bingranl the changes were merged yesterday and will be in a nightly shortly

@big-guy big-guy closed this as completed Sep 22, 2022
@bingranl
Copy link
Author

Thanks for the updates, @big-guy !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:bug @core Issue owned by GBT Core in:dependency-resolution engine metadata
Projects
None yet
Development

No branches or pull requests

4 participants