Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#2391] Add @since tag to Project.findProperty() #2403

Merged
merged 1 commit into from Jul 10, 2017

Conversation

szpak
Copy link
Contributor

@szpak szpak commented Jul 6, 2017

Context

In relation to #2391. The method in Project which I was struggling recently in which version was added to declare compatibility range of my plugin.

Related release notes.

Contributor Checklist

  • Review Contribution Guidelines
  • Sign Gradle CLA
  • [N/A] Link to Design Spec for changes that affect more than 1 public API (that is, not in an internal package) or updates to > 20 files
  • [N/A] Provide integration tests (under <subproject>/src/integTest) to verify changes from a user perspective
  • [N/A] Provide unit tests (under <subproject>/src/test) to verify logic
  • [N/A] Update User Guide, DSL Reference, and Javadoc for public-facing changes
  • [N/A] Ensure that tests pass locally: ./gradlew quickCheck <impacted-subproject>:check

Gradle Core Team Checklist

  • Verify design and implementation
  • Verify test coverage and CI build status
  • Verify documentation including proper use of @since and @Incubating annotations for all public APIs
  • Recognize contributor in release notes

@szpak szpak changed the title [#276] Add @since tag to Project.findProperty() [#2391] Add @since tag to Project.findProperty() Jul 6, 2017
@eriwen eriwen added this to the 4.1 RC1 milestone Jul 7, 2017
@eriwen eriwen removed this from the 4.1 RC1 milestone Jul 7, 2017
@jjohannes jjohannes self-requested a review July 10, 2017 06:33
@jjohannes jjohannes merged commit 5696826 into gradle:master Jul 10, 2017
@szpak szpak deleted the findPropertySinceVersion branch July 10, 2017 07:52
@jjohannes
Copy link
Contributor

Good catch @szpak! Will be in Gradle 4.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants