Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TAPI getEditableBuilds() does not return builds included by BuildSrc #24672

Open
nskvortsov opened this issue Apr 6, 2023 · 4 comments
Open
Labels
a:bug has:reproducer Indicates the issue has a confirmed reproducer in:ide Issues related to using Gradle with an IDE like IntelliJ, Eclipse or Android Studio in:tooling-api

Comments

@nskvortsov
Copy link
Contributor

Expected Behavior

getEditableBuilds includes builds included by the buildSrc build
https://docs.gradle.org/current/javadoc/org/gradle/tooling/model/gradle/GradleBuild.html#getEditableBuilds--

Current Behavior

getEditableBuilds resturns an empty collection when called on a buildSrc project.

Context

IDEA 2023.1 tries to import all projects in a single pass. Projects included by buildSrc are missing: https://youtrack.jetbrains.com/issue/IDEA-316576/Regression-in-2023.1-Builds-included-by-buildSrc-are-no-longer-imported

Steps to Reproduce

Attaching Sample project + Sample TAPI client. Please run TAPI client (gradlew :run) to observe different lists of builds obtained by getIncludedBuilds, getEditableBuilds or both.
buildSrc-includedBuild.zip

Your Environment

Build scan URL

:

@jbartok
Copy link
Member

jbartok commented Apr 7, 2023

Thank you for providing a valid reproducer.

The issue is in the backlog of the relevant team and is prioritized by them.

@jbartok jbartok added in:tooling-api in:ide Issues related to using Gradle with an IDE like IntelliJ, Eclipse or Android Studio has:reproducer Indicates the issue has a confirmed reproducer and removed to-triage labels Apr 7, 2023
@reinsch82 reinsch82 self-assigned this Apr 21, 2023
@FrauBoes
Copy link
Contributor

Added an integration test to reproduce the issue. IIUC, editable builds should include the included builds.

@donat
Copy link
Member

donat commented Jun 20, 2023

@FrauBoes will you have time to finish this or should we take over?

@donat donat assigned FrauBoes and unassigned reinsch82 Jun 20, 2023
@FrauBoes
Copy link
Contributor

@donat I won't get to it any time soon, feel free to take over.

@FrauBoes FrauBoes removed their assignment Jun 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:bug has:reproducer Indicates the issue has a confirmed reproducer in:ide Issues related to using Gradle with an IDE like IntelliJ, Eclipse or Android Studio in:tooling-api
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants