Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Intercept getters (and setters) in Groovy closures #24716

Closed
asodja opened this issue Apr 11, 2023 · 2 comments
Closed

Intercept getters (and setters) in Groovy closures #24716

asodja opened this issue Apr 11, 2023 · 2 comments
Assignees
Labels
in:provider-api property lazy provider MapProperty ListProperty DirectoryProperty p:lazy-migration Issues covered by migration to an all-lazy API
Milestone

Comments

@asodja
Copy link
Member

asodja commented Apr 11, 2023

Groovy creates a different signature for getters in closures, e.g.:

tasks.register("myCheckstyle", Checkstyle) {
      maxErrors = 2
      int currentMaxErrors = maxErrors // <- getter call here
      assert currentMaxErrors == 2
}

We currently don't intercept that. Lets improve our logic and fix that.

@asodja asodja added in:provider-api property lazy provider MapProperty ListProperty DirectoryProperty @execution labels Apr 11, 2023
@h0tk3y
Copy link
Member

h0tk3y commented May 2, 2023

Progress in #24949

@lptr lptr added the p:lazy-migration Issues covered by migration to an all-lazy API label May 30, 2023
@h0tk3y
Copy link
Member

h0tk3y commented Jul 25, 2023

Done in #24949.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in:provider-api property lazy provider MapProperty ListProperty DirectoryProperty p:lazy-migration Issues covered by migration to an all-lazy API
Projects
None yet
Development

No branches or pull requests

4 participants