Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make all injector-getters abstract in public types #28435

Open
lptr opened this issue Mar 12, 2024 · 0 comments
Open

Make all injector-getters abstract in public types #28435

lptr opened this issue Mar 12, 2024 · 0 comments
Labels
a:chore Minor issue without significant impact in:core-utilities base services
Milestone

Comments

@lptr
Copy link
Member

lptr commented Mar 12, 2024

We use two different syntaxes for getter-injection in tasks and elsewhere:

    @Inject
    protected BuildOperationRunner getBuildOperationRunner() {
        throw new UnsupportedOperationException();
    }

and:

    @Inject
    protected abstract BuildOperationRunner getBuildOperationRunner();

We should refactor the former ones to the latter, as it's more concise. The change is technically a breaking change, though it's unlikely to affect code out there. Still, it'd be prudent to do it in a major release.

@lptr lptr added the in:core-utilities base services label Mar 12, 2024
@lptr lptr added this to the 9.0 RC1 milestone Mar 12, 2024
@ov7a ov7a added a:chore Minor issue without significant impact and removed to-triage labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:chore Minor issue without significant impact in:core-utilities base services
Projects
None yet
Development

No branches or pull requests

2 participants