Ignored TestNG tests should not throw an exception #3570
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for providing the pull request. I am going to have a look tomorrow. |
bmuschko
reviewed
Nov 21, 2017
| @@ -74,4 +75,19 @@ class TestNGTestFrameworkIntegrationTest extends AbstractTestFrameworkIntegratio | |||
| String getFailingTestCaseName() { | |||
| return "fail" | |||
| } | |||
|
|
|||
| @Issue("GRADLE-3545") | |||
There was a problem hiding this comment.
Could you use the GitHub issue URL here and in the other places e.g. Issue("https://github.com/gradle/gradle/issues/3545")?
There was a problem hiding this comment.
In retrospect, this makes a lot of sense. Updated!
Issue: #3545 A bug in TestNG can cause the onAfterClass hook in a test listener to run more than once for the same test class. This change will make sure that Gradle handles this gracefully.
|
Thanks so much. It has been merged. |
bmuschko
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #3545
A bug in TestNG can cause the onAfterClass hook in a test listener to
run more than once for the same test class. This change will make sure
that Gradle handles this gracefully.
Gradle Core Team Checklist