Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix documentation distribution plugin #4880

Merged

Conversation

fnegre
Copy link
Contributor

@fnegre fnegre commented Mar 28, 2018

installDist output is by default $buildDir/install/$project.name

Signed-off-by: Florian Nègre granini@gmail.com

Context

Contributor Checklist

  • Review Contribution Guidelines
  • Make sure that all commits are signed off to indicate that you agree to the terms of Developer Certificate of Origin.
  • Check "Allow edit from maintainers" option in pull request so that additional changes can be pushed by Gradle team
  • Provide integration tests (under <subproject>/src/integTest) to verify changes from a user perspective
  • Provide unit tests (under <subproject>/src/test) to verify logic
  • Update User Guide, DSL Reference, and Javadoc for public-facing changes
  • Ensure that tests pass locally: ./gradlew <changed-subproject>:check

Gradle Core Team Checklist

  • Verify design and implementation
  • Verify test coverage and CI build status
  • Verify documentation
  • Recognize contributor in release notes

installDist output is by default $buildDir/install/$project.name

Signed-off-by: Florian Nègre <granini@gmail.com>
@fnegre fnegre mentioned this pull request Mar 28, 2018
11 tasks
@blindpirate blindpirate added a:chore Minor issue without significant impact from:contributor labels Mar 29, 2018
@blindpirate blindpirate merged commit f877993 into gradle:master Mar 29, 2018
@blindpirate
Copy link
Collaborator

Thanks @fnegre !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:chore Minor issue without significant impact
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants