Deprecate buildscript {} in subprojects

[3flex]

Expected Behavior

buildscript {} in subprojects is deprecated.

Current Behavior

No deprecation warning/no message when buildscript {} is used in subprojects.

Context

Comment from @oehme.

Long story to explain why, but I was searching for info about declaring buildscript {} anywhere other than the root build file, and found a definitive comment from @oehme (linked above) that it's a bad idea to do so. Didn't find any existing issue to track it. Seems release of Gradle 5.0 would be an opportune time to deprecate?

Steps to Reproduce (for bugs)

N/A

Your Environment

N/A

[JLLeitschuh]

This would be really unfortunate to see removed.
It's currently the mechanism relied upon to support configuring all of my buildscript code blocks in all sub-projects in one location.

buildscript {
    project.apply {
        from("gradle/repositoryConfig.gradle.kts")
    }
    repositories {
        val buildScriptRepositoryConfig: (RepositoryHandler) -> Unit by extra
        buildScriptRepositoryConfig(this)
    }
    dependencies {
        classpath("org.jetbrains.kotlin:kotlin-gradle-plugin:${property("kotlin.version")}")
    }
}
apply {
    // Gives us access to the extensions declared in the repositoryConfig.gradle.kts file.
    from("gradle/repositoryConfig.gradle.kts")
}
// Configure the sub-project repository resolver first.
subprojects {
    buildscript.repositories {
        val buildScriptRepositoryConfig: (RepositoryHandler) -> Unit by rootProject.extra
        buildScriptRepositoryConfig(this)
    }
}

@oehme is your plan to remove support for the buildscript block in sub-project script files as well?? If that's the case this might be a non-issue (for me at least).

[oehme]

Not sure I understand the "as well". It's the same thing.

[3flex]

Ping... Could this be deprecated in Gradle 6.0 so support could be removed in Gradle 7?

[stale]

This issue has been automatically marked as stale because it has not had recent activity. Given the limited bandwidth of the team, it will be automatically closed if no further activity occurs. If you're interested in how we try to keep the backlog in a healthy state, please read our blog post on how we refine our backlog. If you feel this is something you could contribute, please have a look at our Contributor Guide. Thank you for your contribution.

[JLLeitschuh]

@gradle/core is this on the queue for idiomatic Gradle?