Task action implementation is not tracked when added via Task.doLast(String, Action)

[wolfs]

@wolfs commented on Tue Dec 04 2018

See gradle/kotlin-dsl-samples#1271

The underlying issue is that we don't unpack ConfigureUtil.WrappedConfigureAction which is created by the Closure accepting method created by our runtime task decoration.

[wolfs]

@jjohannes Can you maybe look into fixing this, given that you introduced the method(s)? I can give some guidance.

[lptr]

I'm guessing this is not true anymore?

[wolfs]

I am pretty sure it still is. At least I don't remember fixing anything in that area.

[lptr]

IIRC, we did track unnamed additional actions properly, it was only an issue with the (then) newly added named actions. If you look at the code we are now calling through from unnamed to named, so either we don't have the problem or we have the problem with unnamed actions, too.

I'd be pretty surprised if we had a problem with tracking the implementation of unnamed actions, as we have tests for that case.

[lptr]

Ah, is this not about the "new" methods adding the String parameter, but the methods taking Closure?

The underlying issue is that we don't unpack ConfigureUtil.WrappedConfigureAction which is created by the Closure accepting method created by our runtime task decoration.

Those methods are gone now. Does that change the situation?

We do unwrap WrappedConfigurationAction here, but it's not related:

gradle/subprojects/core/src/main/java/org/gradle/api/internal/tasks/properties/bean/NestedRuntimeBeanNode.java

Lines 63 to 67 in d9f98fe

	// Same as above, if we have wrapped a closure in a WrappedConfigureAction or a ClosureBackedAction, we want to
	// track the closure itself, not the action class.
	if (bean instanceof ConfigureUtil.WrappedConfigureAction) {
	return ((ConfigureUtil.WrappedConfigureAction)bean).getConfigureClosure().getClass();
	}

[stale]

This issue has been automatically marked as stale because it has not had recent activity. Given the limited bandwidth of the team, it will be automatically closed if no further activity occurs. If you're interested in how we try to keep the backlog in a healthy state, please read our blog post on how we refine our backlog. If you feel this is something you could contribute, please have a look at our Contributor Guide. Thank you for your contribution.

[wolfs]

We should fix this.

[stale]

This issue has been automatically closed due to inactivity. If you can reproduce this on a recent version of Gradle or if you have a good use case for this feature, please feel free to reopen the issue with steps to reproduce, a quick explanation of your use case or a high-quality pull request.

[lptr]

Let's keep this open...

[stale]

This issue has been automatically marked as stale because it has not had recent activity. Given the limited bandwidth of the team, it will be automatically closed if no further activity occurs. If you're interested in how we try to keep the backlog in a healthy state, please read our blog post on how we refine our backlog. If you feel this is something you could contribute, please have a look at our Contributor Guide. Thank you for your contribution.

[lptr]

Woo-hoo! 🎉