Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Project.file supports java.nio.file.Path instances. #813

Closed
wants to merge 4 commits into from

Conversation

kelemen
Copy link
Contributor

@kelemen kelemen commented Nov 5, 2016

Provides support for Path instances in API calls taking an Object (most notably, Project.file) for Path instances using the default file system.

Any of the checked boxes below indicate that I took action:

@lacasseio
Copy link
Contributor

lacasseio commented Jan 13, 2017

Thanks @kelemen for the PR. Could you update the user guide and sample (as an example, see the Working with Files section of the user guide)? Thanks!

@kelemen
Copy link
Contributor Author

kelemen commented Jan 13, 2017

I have updated the user guide and also merged master for convenience.

@lacasseio lacasseio self-assigned this Jan 18, 2017
lacasseio pushed a commit that referenced this pull request Jan 18, 2017
@lacasseio
Copy link
Contributor

Thanks @kelemen for your contribution. I cherry picked your changes and did minor typos changes. I merged your changes into master so I will close the PR.

@lacasseio
Copy link
Contributor

@kelemen Would you be interested in an additional contribution and looking into improving Gradle's handling of NIO Path in general? Have a look at issue #1205. Zero pressure on you to address this, but, if you want, we can discuss on the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants