Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Store content hashes in cached artifacts and use it while loading from cache #9032

Open
wolfs opened this issue Jul 27, 2018 · 2 comments
Open
Labels
a:feature A new functionality in:build-cache

Comments

@wolfs
Copy link
Member

wolfs commented Jul 27, 2018

Instead of rebuilding the tree hashes/file hashes when loading from the cache, we should store the hashes in the cache artifact and use them when loading from the cache instead of re-hashing the files.

This also means that we would be able to reuse the data while unpacking cached artifacts.

@lptr lptr changed the title Store content hashes in cached artifacts Store content hashes in cached artifacts and use it while loading from cache Aug 28, 2018
@lptr lptr transferred this issue from another repository Apr 15, 2019
@lptr
Copy link
Member

lptr commented Jan 8, 2020

From @britter on how it is now solved:

The entry point to this is FingerprintCache and it is used in CachingRegularFileHasher and CachingResourceHasher.

@wolfs wolfs added this to the 6.6 RC1 milestone May 7, 2020
@wolfs wolfs removed this from the 6.6 RC1 milestone Jun 4, 2020
@stale
Copy link

stale bot commented Apr 17, 2022

This issue has been automatically marked as stale because it has not had recent activity. Given the limited bandwidth of the team, it will be automatically closed if no further activity occurs. If you're interested in how we try to keep the backlog in a healthy state, please read our blog post on how we refine our backlog. If you feel this is something you could contribute, please have a look at our Contributor Guide. Thank you for your contribution.

@stale stale bot added the stale label Apr 17, 2022
@wolfs wolfs removed the stale label Apr 19, 2022
@ov7a ov7a added the a:feature A new functionality label Aug 10, 2023
@lptr lptr removed the @execution label Feb 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:feature A new functionality in:build-cache
Projects
None yet
Development

No branches or pull requests

4 participants