Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kotlin DSL GenerateScriptPluginAdapters name collisions #9244

Open
JLLeitschuh opened this issue Dec 6, 2018 · 1 comment
Open

Kotlin DSL GenerateScriptPluginAdapters name collisions #9244

JLLeitschuh opened this issue Dec 6, 2018 · 1 comment

Comments

@JLLeitschuh
Copy link
Contributor

There are various examples of filenames that will cause class name collisions. Here are a few examples that will fail.

@Test
fun `script name collision test`() {
    val script1 =
        newFile("file#22.gradle.kts")
    val script2 =
        newFile("file,22.gradle.kts")

    val scriptPlugin1 = ScriptPlugin(script1)
    val scriptPlugin2 = ScriptPlugin(script2)

    assertThat(
        scriptPlugin1.simplePluginAdapterClassName,
        not(equalTo(scriptPlugin2.simplePluginAdapterClassName)))
}

The above names will also colide with file🏗22.gradle.kts. The team may want to consider some sort of encoding scheme that handles these sorts of collisions.

@eskatos eskatos changed the title GenerateScriptPluginAdapters name collisions Kotlin DSL GenerateScriptPluginAdapters name collisions Apr 19, 2019
@eskatos eskatos transferred this issue from gradle/kotlin-dsl-samples Apr 25, 2019
@stale
Copy link

stale bot commented Sep 6, 2020

This issue has been automatically marked as stale because it has not had recent activity. Given the limited bandwidth of the team, it will be automatically closed if no further activity occurs. If you're interested in how we try to keep the backlog in a healthy state, please read our blog post on how we refine our backlog. If you feel this is something you could contribute, please have a look at our Contributor Guide. Thank you for your contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants