This repository has been archived by the owner on Aug 19, 2020. It is now read-only.
Let the kotlin-dsl plugin configure precompiled script plugins support #1135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
and java-gradle-plugin to enable support for precompiled script plugins out of the box existing functionality moved up to a kotlin-dsl.base plugin Signed-off-by: Paul Merlin <paul@gradle.com>
Signed-off-by: Paul Merlin <paul@gradle.com>
Signed-off-by: Paul Merlin <paul@gradle.com>
Signed-off-by: Paul Merlin <paul@gradle.com>
Signed-off-by: Paul Merlin <paul@gradle.com>
Signed-off-by: Paul Merlin <paul@gradle.com>
Signed-off-by: Paul Merlin <paul@gradle.com>
bamboo
suggested changes
Sep 25, 2018
| @@ -376,15 +374,14 @@ class PrecompiledScriptPluginTest : AbstractPluginTest() { | |||
| .loadClass(className) | |||
|
|
|||
| private | |||
| fun withPrecompiledScriptPluginsPlus(vararg additionalPlugins: String) = | |||
| withBuildScript(scriptWithPrecompiledScriptPluginsPlus(*additionalPlugins)) | |||
| fun withKotlinDslPluginPlus(vararg additionalPlugins: String) = | |||
There was a problem hiding this comment.
⭕️ it seems the parameter is no longer used.
| @@ -55,7 +58,7 @@ open class EmbeddedKotlinPlugin @Inject internal constructor( | |||
| embeddedKotlinConfiguration.name, | |||
| "stdlib-jdk8", "reflect") | |||
|
|
|||
| listOf("compileOnly", "testImplementation").forEach { | |||
| listOf(COMPILE_ONLY_CONFIGURATION_NAME, TEST_IMPLEMENTATION_CONFIGURATION_NAME).forEach { | |||
There was a problem hiding this comment.
❌ How about we share this list as a constant with the KotlinDslBasePlugin?
Signed-off-by: Paul Merlin <paul@gradle.com>
from EmbeddedKotlinPlugin and KotlinDslBasePlugin Signed-off-by: Paul Merlin <paul@gradle.com>
|
Thanks @bamboo, ready for another round |
eskatos
deleted the
eskatos/plugins/kotlin-dsl-applies-precompiled-scripts-plugin
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One can still opt-out by only applying
kotlin-dsl-base.