This repository has been archived by the owner on Aug 19, 2020. It is now read-only.
Precompute message in order not to leak Project instance #1188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The KotlinCompile task logger goes through RMI to the Kotlin Compiler daemon. Holding a Project instance per task exacerbated a memory leak in the Kotlin compiler infrastructure. Signed-off-by: Paul Merlin <paul@gradle.com>
oehme
approved these changes
Oct 17, 2018
...ojects/plugins/src/main/kotlin/org/gradle/kotlin/dsl/plugins/dsl/KotlinDslCompilerPlugins.kt
Outdated
Show resolved
Hide resolved
to preallocate two smaller strings ahead and build the whole message when it's actually needed Signed-off-by: Paul Merlin <paul@gradle.com>
|
If you can't use Gradle 5 and are impacted by this leak, setting |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The KotlinCompile task logger goes through RMI to the Kotlin Compiler daemon. Holding a Project instance per task exacerbated a memory leak in the Kotlin compiler infrastructure.
This only impacted
KotlinCompiletasks with thekotlin-dslplugin applied.Also see https://youtrack.jetbrains.com/issue/KT-27639