You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Apr 21, 2020. It is now read-only.
Some organizations might have multiple plugin repositories are a developer might want to try out a plugin deployed to mavenLocal() before pushing a change. Allowing multiple Maven repositories will solve these use cases.
Proposed Change
Instead of passing a single repository URL to the ScriptHandler of the current build script, we need to globally add the declared plugin repositories to the locations from where plugin jars are resolved. The current idea is to prepend them to the repositories of each initScript/buildScript block.
Each repository will be added to the list of plugin resolvers as a separate resolver. This will give the user better diagnostic messages and will later enable us to insert the Gradle Plugin Portal at any location between other repositories, see #22.
Code Review
[] Does the change work?
[] Try out the feature, executing it like a end-user would.
[] Check corner cases and try to break it in various ways.
[] Are the error messages informative?
[] Is the change sufficiently tested?
[] Are there appropriate levels of unit & integration tests?
[] Do the tests indicate what they are actually testing?
[] Are the tests in the right location?
[] Can new tests be consolidated with any existing tests?
Motivation
Some organizations might have multiple plugin repositories are a developer might want to try out a plugin deployed to
mavenLocal()
before pushing a change. Allowing multiple Maven repositories will solve these use cases.Proposed Change
Instead of passing a single repository URL to the
ScriptHandler
of the current build script, we need to globally add the declared plugin repositories to the locations from where plugin jars are resolved. The current idea is to prepend them to the repositories of eachinitScript
/buildScript
block.Each repository will be added to the list of plugin resolvers as a separate resolver. This will give the user better diagnostic messages and will later enable us to insert the Gradle Plugin Portal at any location between other repositories, see #22.
Code Review
The text was updated successfully, but these errors were encountered: