Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding a new dedicated workflow for validation should be discouraged #94

Closed
erichaagdev opened this issue Mar 13, 2023 · 2 comments
Closed

Comments

@erichaagdev
Copy link
Member

Adding a new dedicated workflow for validation should be discouraged. A new dedicated workflow will not stop any other workflows from running that may execute a Gradle wrapper. In other words, if a bad wrapper is contributed then by the time the wrapper validation fails, or by the time a maintainer notices, the bad wrapper may have already been executed in other workflows.

The Add a new dedicated Workflow section should either be removed, or strongly discouraged. The recommendation should be to add the validation immediately after checkout on any workflow that may execute a Gradle wrapper.

@JLLeitschuh
Copy link
Contributor

I think that's reasonable. I think that maybe offering a "here's the best way to do this" and a "here's how to do this if you're just using this GH action alone, and your CI is executed elsewhere"?

@bigdaz
Copy link
Member

bigdaz commented Feb 10, 2024

I think this should be done as part of gradle/actions#12.

With that work, we'll likely deprecate this action and possibly add a dedicated gradle/actions/wrapper-validation. Ideally, wrapper checks will happen transparently and automatically.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants