Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix max steps validation key error #31

Merged
merged 12 commits into from
Aug 26, 2021
Merged

Fix max steps validation key error #31

merged 12 commits into from
Aug 26, 2021

Conversation

aniketmaurya
Copy link
Contributor

@aniketmaurya aniketmaurya commented Aug 26, 2021 •
edited
Loading

Changes

Fixes # (issue)

Type of change

  • Documentation Update
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

deepsource-autofix bot and others added 3 commits August 26, 2021 12:10
@deepsource-autofix
Format code with black and isort
befac78 
This commit fixes the style issues introduced in 5da5c85 according to the output
from black and isort.

Details: https://deepsource.io/gh/gradsflow/gradsflow/transform/a8665af4-e9fa-4b00-8d8a-5457625e6716/
@aniketmaurya
update
0cbe863
@aniketmaurya
fix
b7970f3
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

@aniketmaurya aniketmaurya changed the title Fix max steps Fix max steps validation key error Aug 26, 2021
@codecov
Copy link

codecov bot commented Aug 26, 2021 •
edited
Loading

Codecov Report

Merging #31 (3454f42) into main (0eae032) will increase coverage by 1.67%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #31      +/-   ##
==========================================
+ Coverage   95.96%   97.63%   +1.67%     
==========================================
  Files          17       17              
  Lines         248      254       +6     
==========================================
+ Hits          238      248      +10     
+ Misses         10        6       -4
Flag Coverage Δ
unittests 97.63% <100.00%> (+1.67%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
tests/tasks/test_image.py 100.00% <ø> (ø)
gradsflow/core/automodel.py 95.65% <100.00%> (+2.00%) ⬆️
tests/core/test_automodel.py 100.00% <100.00%> (+21.42%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5da5c85...3454f42. Read the comment docs.

@aniketmaurya aniketmaurya enabled auto-merge (squash) August 26, 2021 13:17
@sonarcloud
Copy link

sonarcloud bot commented Aug 26, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@aniketmaurya aniketmaurya merged commit 399b536 into main Aug 26, 2021
@aniketmaurya aniketmaurya deleted the fix_max_steps branch August 27, 2021 00:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
example test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@aniketmaurya