Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Installing grafana-client 4.1 broke my Boto3 connections #179

Open
alkuzad opened this issue Jul 13, 2024 · 1 comment
Open

Installing grafana-client 4.1 broke my Boto3 connections #179

alkuzad opened this issue Jul 13, 2024 · 1 comment

Comments

@alkuzad
Copy link

alkuzad commented Jul 13, 2024

Describe the bug

Niquests uses urllib3.future library that replaces urllib3 library even if you installed both, so installing two will conflict.

You either guarantee that grafana-client works or boto3 works but not in the same time.

To Reproduce
Steps to reproduce the behavior:

  1. rm -rf test && python3 -mvenv test && . ./test/bin/activate && pip install boto3 1>/dev/null && cat test/lib/python3.12/site-packages/urllib3/_version.py && pip install grafana-client 1> /dev/null && cat test/lib/python3.12/site-packages/urllib3/_version.py

Expected behavior

I would see both times:

__version__ = "2.2.2"

Instead of it changing to this on second print:

__version__ = "2.8.902"

Versions

  • Grafana: None
  • grafana-client: [ grafana-client==4.1.0 ]
  • Authentication: None

Additional context

Grafana-client is a library often used by DevOps who also use boto3 or other libraries together connecting different systems and platforms together. Adding a dependency for library that eradicates proper urllib3 and introduces new bugs that breaks environment is problematic. We can no longer add grafana-client into our common toolset and we have to extract it to another tool or use pre 4.0 version.

Async is nice but it was proven that it is not main contributor to the speed . Adding support for it easily is ok but not at cost of breaking other flows.

@dg-nvm
Copy link

dg-nvm commented Jul 15, 2024

I created this constraint file that helps with the issue - effectivelly automatically lowers the grafana-client version to one that uses requests - https://github.com/alkuzad/python-global-constraints

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants