Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modernize code base for pandas 2.x and beyond #16

Open
amotl opened this issue Apr 29, 2023 · 0 comments
Open

Modernize code base for pandas 2.x and beyond #16

amotl opened this issue Apr 29, 2023 · 0 comments

Comments

@amotl
Copy link
Contributor

amotl commented Apr 29, 2023

Hi there,

at GH-15, @bukowa asked for some adjustments for their use case. On the other hand, I think the code should probably be validated to work with all of Python 3.11, Grafana 9, and pandas 2.x these days.

Just having a look at two forks of the project, I discovered BP2022-AP1@79ec4cfdcb67 and BP2022-AP1@dd92d43d987 by @LucasDerReisende as well as jakubjezek001@5ca76493bce0e7 by @jakubjezek001 1.

I think it will be sweet to integrate those modernizations into the main code base. Maybe you could submit corresponding patches?

With kind regards,
Andreas.

Footnotes

  1. Using f-strings makes sense, and also using some basic list comprehensions like compressing for col in df:. However, I don't like compressing code too much like freq = str(req.get("intervalMs")) + "ms" if "intervalMs" in req else None.

@amotl amotl changed the title Modernize code base for pandas 2.x Modernize code base for pandas 2.x and beyond Apr 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant