Fix implementation flaw reported at #32

TypeError: '<' not supported between instances of 'dict' and 'dict'
grafana-toolbox · Mar 25, 2022 · 6e3b440 · 6e3b440
1 parent 3d7dc3c
commit 6e3b440
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/CHANGES.rst b/CHANGES.rst
@@ -18,6 +18,7 @@ in progress
 - Tests: Make test case for `explore datasources` use _two_ data sources
 - Tests: Mimic Grafana 7/8 on datasource references within dashboards, newer
   versions have objects (uid, type) instead of bare names
+- Fix implementation flaw reported at #32. Thanks, @IgorOhrimenko and @carpenterbees!
 
 
 2022-02-03 0.13.1

diff --git a/grafana_wtf/core.py b/grafana_wtf/core.py
@@ -495,7 +495,7 @@ def collect_datasource_items(element):
                     ds = dict(ds)
                 if ds not in items:
                     items.append(ds)
-        return sorted(items)
+        return items
 
     def index_dashboards(self):