Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix go 1.15 conversion from int to string #113

Merged
merged 1 commit into from Oct 12, 2020

Conversation

jorgelbg
Copy link
Contributor

@jorgelbg jorgelbg commented Oct 1, 2020

Currently with go v1.15 it is not possible to build the project because of the deprecation of the int to string conversion. See golang/go#32479.

I didn't include the Go 1.15 version in the README nor compatibility matrix because the change is backwards compatible. But it could be done eventually.

Currently with go v1.15 release it is not possible to build the project
because of the deprecation of the `int` to `string` conversion. See
golang/go#32479.
@coveralls
Copy link

Coverage Status

Coverage remained the same at 47.554% when pulling 279636e on jorgelbg:go-1.15 into 0a69ce5 on grafana-tools:master.

Copy link
Collaborator

@GiedriusS GiedriusS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you and sorry for the late response. I've been on vacation.

@GiedriusS GiedriusS merged commit 19f4b16 into grafana-tools:master Oct 12, 2020
@jorgelbg jorgelbg deleted the go-1.15 branch October 12, 2020 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants