Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move test to *_test package #22

Merged
merged 1 commit into from
Sep 5, 2018
Merged

Conversation

IndraGunawan
Copy link
Contributor

No description provided.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 22.476% when pulling a518f26 on bukalapak:fix-tests into 9f33c0d on grafana-tools:master.

@grafov
Copy link
Member

grafov commented Sep 5, 2018

It is reasonable changing. But if were we put tests inside the testable package we could use any internal structures of this package. Though now the project have no such tests where we check internal structures or functions of SDK :) So ok, let move the tests to a separate test package. For code clarity.

@grafov grafov merged commit 767d34f into grafana-tools:master Sep 5, 2018
@IndraGunawan IndraGunawan deleted the fix-tests branch September 5, 2018 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants