Add alertnotification API support #53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a new member to the `Datasource` struct called SecureJSONData which gets passed as `secureJsonData`. This is needed because certain features are only available via that e.g. passing custom header values. Signed-off-by: Giedrius Statkevičius <giedriuswork@gmail.com>
Add `alertnotification.go` which contains the struct definition of an `alertnotification`. Add `rest-alertnotification.go` which contains the API wrappers. Edit `panel.go` to remove the old definition of an alertnotification since it is not complete and it belongs in its own file. Signed-off-by: Giedrius Statkevičius <giedriuswork@gmail.com>
It is actually simply `/api/alert-notifications/:id`
grafov
approved these changes
Jan 14, 2020
|
Well, the proposed changes look good for me. Let merge them. If you could decide to add the tests it will be great though :) |
|
@GiedriusS thank you for this contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
alertnotification.gowhich contains the struct definition of analertnotification. Addrest-alertnotification.gowhich contains theAPI wrappers. Edit
panel.goto remove the old definition of analertnotification since it is not complete and it belongs in its own
file.
Tested with internal integration tests with Grafana 6.5.2.
PR is based on my other PR: #52