-
Notifications
You must be signed in to change notification settings - Fork 184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add support for creating, patching, deleting and getting annotations #66
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few minor things but overall LGTM! Also, thank you so much for adding that new param type just like we've talked in the open issue! Much appreciated ❤️
I didn't even see #47 - happy to get you guys started 😄 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Let's wait for a few days to see if anyone else wants to review (:
Thanks! My only little pet peeve of this PR is that in the future we might have other calls with parameters that have the same names so we will have collisions. But, time will tell and that will be refactored (before 1.0) to avoid this problem. |
@pmenglund @GiedriusS github.com/grafana-tools/sdk./rest-annotation.go:158:25: syntax error: unexpected _000_000 at end of statement https://github.com/grafana-tools/sdk/blob/master/rest-annotation.go#L158 --> This looks like an invalid syntax. |
I see, thanks for your report! But only on <1.13 versions because in 1.13 support for underscores has been added. I will fix this soon + add extra versions to our CI to catch these in the future. |
@ankit-arecabay #70 PTAL. |
No description provided.