Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Requests by uid #69

Merged
merged 5 commits into from
Mar 5, 2020
Merged

Requests by uid #69

merged 5 commits into from
Mar 5, 2020

Conversation

UndeadJoe
Copy link

@UndeadJoe UndeadJoe commented Feb 25, 2020 •
edited

Get dashboard by UID instead of slug string

@coveralls
Copy link

coveralls commented Feb 25, 2020 •
edited

Coverage Status

Coverage increased (+5.7%) to 42.555% when pulling a1ac672 on UndeadJoe:uid-requests into ab16bd9 on grafana-tools:master.

@UndeadJoe UndeadJoe changed the title Requests by uid in master Requests by uid Feb 27, 2020
GiedriusS
GiedriusS approved these changes Mar 5, 2020
View reviewed changes
Copy link
Collaborator

@GiedriusS GiedriusS left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! There are some issues but I will fix them myself in a follow-up PR. This is because this doesn't break anything :-)

rest-dashboard.go Show resolved Hide resolved
rest-dashboard.go Show resolved Hide resolved
rest-dashboard_integration_test.go Show resolved Hide resolved
@GiedriusS GiedriusS merged commit 47f19f1 into grafana-tools:master Mar 5, 2020
@UndeadJoe
Copy link
Author

Thank you @GiedriusS

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GiedriusS GiedriusS GiedriusS approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@UndeadJoe @coveralls @GiedriusS