Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow the project used by Stackdriver targets to be specified #95

Merged
merged 1 commit into from Jul 7, 2020
Merged

Allow the project used by Stackdriver targets to be specified #95

merged 1 commit into from Jul 7, 2020

Conversation

K-Phoen
Copy link
Contributor

@K-Phoen K-Phoen commented Jul 1, 2020

By default, Grafana will use the Google Cloud project defined in the JWT token given when creating the data source. In some cases, referencing another project while still using the same data source is desired.
For these use cases, I add the ProjectName field to the Target struct.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 47.46% when pulling 8dffc66 on K-Phoen:stackdriver-project-name into 622ba1f on grafana-tools:master.

GiedriusS
GiedriusS approved these changes Jul 7, 2020
View reviewed changes
Copy link
Collaborator

@GiedriusS GiedriusS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, this exists at the very least on 6.7.4 & 7.0.3.

@GiedriusS GiedriusS merged commit 904dd74 into grafana-tools:master Jul 7, 2020
@K-Phoen K-Phoen deleted the stackdriver-project-name branch July 10, 2020 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GiedriusS GiedriusS GiedriusS approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@K-Phoen @coveralls @GiedriusS