Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

module.git should not reload flow components every time it polls #5028

Closed
erikbaranowski opened this issue Aug 30, 2023 · 2 comments · Fixed by #5054
Closed

module.git should not reload flow components every time it polls #5028

erikbaranowski opened this issue Aug 30, 2023 · 2 comments · Fixed by #5054
Assignees
Labels
bug Something isn't working frozen-due-to-age Locked due to a period of inactivity. Please open new issues or PRs if more discussion is needed.
Milestone

Comments

@erikbaranowski
Copy link
Contributor

What's wrong?

module loaders commonly poll but they should not reload flow components unless a change is detected to the content of the module loader.

Steps to reproduce

use module.git and observe that components are restarted without modification each time it polls.

return c.mod.LoadFlowContent(args.Arguments, string(bb))

System information

No response

Software version

No response

Configuration

No response

Logs

No response

@erikbaranowski erikbaranowski added the bug Something isn't working label Aug 30, 2023
@rfratto
Copy link
Member

rfratto commented Aug 30, 2023

Should the module code in Flow ignore calls to LoadConfig if the config bytes are unchanged? That would make this change available to all module loader components instead of just module.git.

@mattdurham
Copy link
Collaborator

That would work as long as we assume all child modules are updating when appropriate. Which I think is a safe assumption.

@erikbaranowski erikbaranowski self-assigned this Aug 31, 2023
@erikbaranowski erikbaranowski added this to the v0.37.0 milestone Aug 31, 2023
@github-actions github-actions bot added the frozen-due-to-age Locked due to a period of inactivity. Please open new issues or PRs if more discussion is needed. label Feb 21, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working frozen-due-to-age Locked due to a period of inactivity. Please open new issues or PRs if more discussion is needed.
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

3 participants